Unlocked pages flushed

[Rajat <sharma.rajat@hcl.in>]

Hi List,

While flushing the data through nfs_file_flush, I observed that pages are 
being flushed in unlocked state. nfs_file_flush call graph reaches to 
nfs_flush_one where the comment above this definition states "The page must 
have been locked by the caller." However I have checked with PageLocked() call 
that the pages which enter into nfs_flush_one are not locked. 

What I could make out of it is: this is done porbably to avoid deadlock with 
other functions like prepare_write, commit_write, writepage, readpage where 
page is grabbed first then lock_kernel (HEAVILY used in NFS) is called. 
Whereas nfs_file_flush calls lock_kernel, then enters into nfs_wb_all. So, to 
avoid deadlock, logical place for lock_page loop would have been in 
nfs_file_flush before lock_kernel (still not sure about this, will it help?). 

Here we are flushing pages without honouring page_lock OR am I going wrong 
somewhere???

Rajat


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs