From: Andrew W Elble <aweits@rit.edu>
To: Anthony Messina <amessina@messinet.com>
Cc: Benjamin Coddington <bcodding@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: soft lockup in the laundromat
Date: Tue, 24 Feb 2015 16:12:40 -0500 [thread overview]
Message-ID: <m2pp8zj9o7.fsf@discipline.rit.edu> (raw)
In-Reply-To: 1524803.SbAy9NQUHI@ws1.m.messinet.com
We're running into something very similar.
fs/nfsd/nfs4state.c:
1631 static void
1632 __destroy_client(struct nfs4_client *clp)
1633 {
<snip>
1652 while (!list_empty(&clp->cl_revoked)) {
1653 dp = list_entry(reaplist.next, struct nfs4_delegation, dl_recall_lru);
1654 list_del_init(&dp->dl_recall_lru);
1655 nfs4_put_stid(&dp->dl_stid);
1656 }
shouldn't that be:
1653 dp = list_entry(clp->cl_revoked.next, struct nfs4_delegation, dl_recall_lru);
see commit 2d4a532d385f635ab8243b88db3136bb52a0bc29
?
Thanks,
Andy
--
Andrew W. Elble
aweits@discipline.rit.edu
Infrastructure Engineer, Communications Technical Lead
Rochester Institute of Technology
PGP: BFAD 8461 4CCF DC95 DA2C B0EB 965B 082E 863E C912
next prev parent reply other threads:[~2015-02-24 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 16:36 soft lockup in the laundromat Benjamin Coddington
2015-02-18 20:26 ` Jeff Layton
2015-02-19 1:26 ` Anthony Messina
2015-02-21 2:55 ` Anthony Messina
2015-02-24 21:12 ` Andrew W Elble [this message]
2015-02-25 0:09 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pp8zj9o7.fsf@discipline.rit.edu \
--to=aweits@rit.edu \
--cc=amessina@messinet.com \
--cc=bcodding@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox