From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: linux-nfs@vger.kernel.org
Subject: nfs-utils/idmapd: use of private define breaks with libevent-2.1.x
Date: Sat, 17 Jan 2015 18:25:17 +0000 (UTC) [thread overview]
Message-ID: <pan.2015.01.17.18.25.17@googlemail.com> (raw)
Hello,
The Gentoo community has found a problem with the current release of
nfs-utils, where idmapd uses a not strictly private, yet strongly
discouraged #define.
Bug description with proposed patch:
https://bugs.gentoo.org/show_bug.cgi?id=446374
The code in question:
http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=utils/idmapd/idmapd.c;hb=HEAD#l719
According to:
https://github.com/libevent/libevent/blob/master/include/event2/event_struct.h
which says:
"No field declared in this file should be used directly in user code."
using EVLIST_INIT directly is bound to break. This seems to be a leftover
from legacy code.
A simple fix is attached to the bugzilla above and just calls the
proper public API, which is functionally equivalent to the bit check.
Would be nice to see this in 1.3.2. :)
Thanks!
Holger
next reply other threads:[~2015-01-17 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 18:25 Holger Hoffstätte [this message]
2015-01-23 14:03 ` nfs-utils/idmapd: use of private define breaks with libevent-2.1.x Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pan.2015.01.17.18.25.17@googlemail.com \
--to=holger.hoffstaette@googlemail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox