From: Takashi Iwai <tiwai@suse.de>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Trond.Myklebust@netapp.com, rjw@sisk.pl,
linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: nfs regression 2.6.35+
Date: Mon, 16 Aug 2010 12:09:12 +0200 [thread overview]
Message-ID: <s5h39uedg3b.wl%tiwai@suse.de> (raw)
In-Reply-To: <20100816070626.GA10503@sli10-desk.sh.intel.com>
[Added linux-nfs to Cc]
At Mon, 16 Aug 2010 15:06:26 +0800,
Shaohua Li wrote:
>
> NFS client runs latest git. At client side, use vim to edit a file located at
> NFS server. If I save the file, vim always reports 'E667: Fsync failed'. If I
> revert f7fa16506bf9b6323e862a61e14c20555152bb3, vim works. No kernel errors
> reported.
This hits me, too. Reverting it cures the problem.
(BTW, the correct commit id of the affecting patch is
af7fa16506bf9b6323e862a61e14c20555152bb3
"NFS: Fix up the fsync code")
Reproduced on 2.6.36-rc1.
Looking at strace output,
open("afo", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 4
write(4, "#!/bin\n", 7) = 7
fsync(4) = 1
stat("afo", {st_mode=S_IFREG|0644, st_size=7, ...}) = 0
close(4) = 0
So, fsync() returns 1 wrongly.
thanks,
Takashi
next parent reply other threads:[~2010-08-16 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100816070626.GA10503@sli10-desk.sh.intel.com>
2010-08-16 10:09 ` Takashi Iwai [this message]
2010-08-16 10:40 ` nfs regression 2.6.35+ Takashi Iwai
2010-08-16 16:35 ` Bill Davidsen
2010-08-16 18:17 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h39uedg3b.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).