Linux NFS development
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: nfs@lists.sourceforge.net
Subject: Re: Crash in NFS on 2.5.41
Date: 11 Oct 2002 04:11:23 +0200	[thread overview]
Message-ID: <shsy995sp10.fsf@charged.uio.no> (raw)
In-Reply-To: <1034280084.8583.53.camel@dell_ss3.pdx.osdl.net>

>>>>> " " == Stephen Hemminger <shemminger@osdl.org> writes:

     > This happened when doing a bash completion on an NFS mounted
     > directory.  The server was (at least every other machine still
     > thinks so).

Hmm. Looks like I missed a 'kunmap()' call when I made the RPC code
copy directly into pages. Does the following fix it?

Cheers,
  Trond

--- linux-2.5.41/fs/nfs/dir.c.orig	2002-10-01 19:43:15.000000000 -0400
+++ linux-2.5.41/fs/nfs/dir.c	2002-10-10 22:09:08.000000000 -0400
@@ -130,7 +130,6 @@
 	return 0;
  error:
 	SetPageError(page);
-	kunmap(page);
 	unlock_page(page);
 	invalidate_inode_pages(inode->i_mapping);
 	desc->error = error;



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

      reply	other threads:[~2002-10-11  2:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-10 20:01 Crash in NFS on 2.5.41 Stephen Hemminger
2002-10-11  2:11 ` Trond Myklebust [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=shsy995sp10.fsf@charged.uio.no \
    --to=trond.myklebust@fys.uio.no \
    --cc=nfs@lists.sourceforge.net \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox