From: Dan McGee <dan-fd97jBR+K/6hPH1hqNUYSQ@public.gmane.org>
To: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 1/2] nilfs-tune: add static/const specifiers where applicable
Date: Fri, 23 Dec 2011 09:11:15 -0600 [thread overview]
Message-ID: <1324653076-13692-1-git-send-email-dan@archlinux.org> (raw)
Signed-off-by: Dan McGee <dan-fd97jBR+K/6hPH1hqNUYSQ@public.gmane.org>
---
sbin/nilfs-tune/nilfs-tune.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/sbin/nilfs-tune/nilfs-tune.c b/sbin/nilfs-tune/nilfs-tune.c
index d5bc00f..cd5ef24 100644
--- a/sbin/nilfs-tune/nilfs-tune.c
+++ b/sbin/nilfs-tune/nilfs-tune.c
@@ -100,7 +100,7 @@ const static __u64 clear_ok_features[NILFS_MAX_FEATURE_TYPES] = {
0
};
-int parse_uuid(const char *uuid_string, __u8 *uuid)
+static int parse_uuid(const char *uuid_string, __u8 *uuid)
{
int i;
char p[3];
@@ -126,7 +126,8 @@ int parse_uuid(const char *uuid_string, __u8 *uuid)
return 0;
}
-void parse_options(int argc, char *argv[], struct nilfs_tune_options *opts)
+static void parse_options(int argc, char *argv[],
+ struct nilfs_tune_options *opts)
{
int c;
opts->flags = O_RDONLY;
@@ -274,7 +275,7 @@ static const char *group_string(gid_t gid)
return buf;
}
-static const char *uuid_string(unsigned char *uuid)
+static const char *uuid_string(const unsigned char *uuid)
{
static char buf[256];
@@ -349,7 +350,7 @@ static void print_features(FILE *f, struct nilfs_super_block *sbp)
fputs("\n", f);
}
-void show_nilfs_sb(struct nilfs_super_block *sbp)
+static void show_nilfs_sb(struct nilfs_super_block *sbp)
{
char label[sizeof(sbp->s_volume_name) + 1];
gid_t gid;
@@ -491,7 +492,7 @@ static int update_feature_set(struct nilfs_super_block *sbp,
return ret;
}
-int modify_nilfs(char *device, struct nilfs_tune_options *opts)
+static int modify_nilfs(const char *device, struct nilfs_tune_options *opts)
{
int devfd;
int ret = EXIT_SUCCESS;
@@ -563,7 +564,7 @@ out:
int main(int argc, char *argv[])
{
struct nilfs_tune_options opts;
- char *device;
+ const char *device;
printf("nilfs-tune %s\n", VERSION);
if (argc < 2) {
--
1.7.8.1
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2011-12-23 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 15:11 Dan McGee [this message]
[not found] ` <1324653076-13692-1-git-send-email-dan-fd97jBR+K/6hPH1hqNUYSQ@public.gmane.org>
2011-12-23 15:11 ` [PATCH 2/2] nilfs-tune: catch and handle missing device argument Dan McGee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324653076-13692-1-git-send-email-dan@archlinux.org \
--to=dan-fd97jbr+k/6hph1hqnuysq@public.gmane.org \
--cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).