Linux NILFS development
 help / color / mirror / Atom feed
From: Vyacheslav Dubeyko <slava-yeENwD64cLxBDgjK7y7TUQ@public.gmane.org>
To: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 1/1] nilfs2: add detailed comment about description of  DAT meta-data file's blocks in on-disk segment summary
Date: Thu, 24 May 2012 16:22:03 +0400	[thread overview]
Message-ID: <1337862123.2628.32.camel@slavad-ubuntu-11> (raw)

Hi,

I suggest to add comment with more details about description of data and
b-tree intermediate blocks of the DAT meta-data file in on-disk segment
summary. I think that absence of such comment can lead to
misunderstanding of segment summary's on-disk layout.

With the best regards,
Vyacheslav Dubeyko.
--
From: Vyacheslav Dubeyko <slava-yeENwD64cLxBDgjK7y7TUQ@public.gmane.org>
Subject: [PATCH 1/1] nilfs2: add detailed comment about description of
DAT meta-data file's blocks in on-disk segment summary

This patch adds comment with more details about description of data and
b-tree intermediate blocks of the DAT meta-data file in on-disk segment
summary.

Signed-off-by: Vyacheslav Dubeyko <slava-yeENwD64cLxBDgjK7y7TUQ@public.gmane.org>
---
 include/linux/nilfs2_fs.h |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/include/linux/nilfs2_fs.h b/include/linux/nilfs2_fs.h
index 655213e..630f550 100644
--- a/include/linux/nilfs2_fs.h
+++ b/include/linux/nilfs2_fs.h
@@ -372,7 +372,18 @@ struct nilfs_binfo_v {
 };
 
 /**
- * struct nilfs_binfo_dat - information for the block which belongs to
the DAT file
+ * Description of DAT meta-data file's blocks is a special case of
segment summary.
+ * The description can contain as data blocks as b-tree intermediate
blocks.
+ * The whole number of blocks (including intermediate blocks) is
described
+ * by fi_nblocks field of nilfs_finfo structure. The fi_ndatablk field
keeps
+ * count of data blocks. Firstly, it is described data blocks by means
of
+ * 64-bit block offset number (__le64) which is allocated per block.
+ * Finally, b-tree intermediate blocks are described by nilfs_binfo_dat
+ * structure which is allocated per block.
+ */
+
+/**
+ * struct nilfs_binfo_dat - information for b-tree intermediate block
of the DAT meta-data file
  * @bi_blkoff: block offset
  * @bi_level: level
  * @bi_pad: padding
--


--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

                 reply	other threads:[~2012-05-24 12:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337862123.2628.32.camel@slavad-ubuntu-11 \
    --to=slava-yeenwd64clxbdgjk7y7tuq@public.gmane.org \
    --cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox