Linux NILFS development
 help / color / mirror / Atom feed
From: Dan McGee <dan-fd97jBR+K/6hPH1hqNUYSQ@public.gmane.org>
To: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] lscp: always show snapshots, even if marked minor
Date: Mon,  1 Sep 2014 14:48:46 -0500	[thread overview]
Message-ID: <1409600926-25385-1-git-send-email-dan@archlinux.org> (raw)

When the average user types `lscp` and doesn't see the snapshot they
just tried to make, it can be very confusing. Add an additional check
to ensure snapshots are never omitted from lscp output.

Signed-off-by: Dan McGee <dan-fd97jBR+K/6hPH1hqNUYSQ@public.gmane.org>
---

Thoughts? I notice this quite often due to a "snapshot-on-shutdown" job I have
running on my machine, and it is very odd to not see this snapshot listed next
time I boot up and run `lscp -r | less`.

 bin/lscp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/lscp.c b/bin/lscp.c
index 2de81b6..6803657 100644
--- a/bin/lscp.c
+++ b/bin/lscp.c
@@ -159,7 +159,7 @@ static int lscp_forward_cpinfo(struct nilfs *nilfs,
 			break;
 
 		for (cpi = cpinfos; cpi < cpinfos + n; cpi++) {
-			if (show_all || !nilfs_cpinfo_minor(cpi)) {
+			if (show_all || nilfs_cpinfo_snapshot(cpi) || !nilfs_cpinfo_minor(cpi)) {
 				lscp_print_cpinfo(cpi);
 				rest--;
 			}
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2014-09-01 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01 19:48 Dan McGee [this message]
     [not found] ` <1409600926-25385-1-git-send-email-dan-fd97jBR+K/6hPH1hqNUYSQ@public.gmane.org>
2014-09-02 17:30   ` [PATCH] lscp: always show snapshots, even if marked minor Ryusuke Konishi
     [not found]     ` <20140903.023057.865227985663964185.konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2014-09-09 20:29       ` Ryusuke Konishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409600926-25385-1-git-send-email-dan@archlinux.org \
    --to=dan-fd97jbr+k/6hph1hqnuysq@public.gmane.org \
    --cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox