Linux NILFS development
 help / color / mirror / Atom feed
From: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
To: users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org,
	sandeen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: remove chown from makefiles too?
Date: Fri, 31 Jul 2009 00:53:17 +0900 (JST)	[thread overview]
Message-ID: <20090731.005317.12928769.ryusuke@osrg.net> (raw)
In-Reply-To: <4A71B53D.7070205-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Hi,
On Thu, 30 Jul 2009 09:59:09 -0500, Eric Sandeen <sandeen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Hi, after the setuid bits got removed from the make install process,
> this sort of thing is still left in several Makefiles:
> 
> install-exec-hook:
> 	list='$(sbin_PROGRAMS)'; \
> 	for p in $$list; do \
> 		chown root $(DESTDIR)$(sbindir)/$$p$(EXEEXT); \
> 	done
> 
> But this fails for a normal user installing into a chroot, as an
> rpmbuild by a non-root user might do.
> 
> I don't think there's any reason for the chown; can this just be removed?

Well, I see.

I will once remove the chown and normalize it unless the removal makes
inconvenience to someone.

Thank you for the comment.

Ryusuke Konishi

  parent reply	other threads:[~2009-07-30 15:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-30 14:59 remove chown from makefiles too? Eric Sandeen
     [not found] ` <4A71B53D.7070205-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-07-30 15:53   ` Ryusuke Konishi [this message]
     [not found]     ` <20090731.005317.12928769.ryusuke-sG5X7nlA6pw@public.gmane.org>
2009-07-30 16:25       ` Eric Sandeen
     [not found]         ` <4A71C990.3060804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-07-30 16:45           ` Ryusuke Konishi
     [not found]             ` <20090731.014518.56564034.ryusuke-sG5X7nlA6pw@public.gmane.org>
2009-07-30 17:48               ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090731.005317.12928769.ryusuke@osrg.net \
    --to=ryusuke-sg5x7nla6pw@public.gmane.org \
    --cc=sandeen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox