Linux NILFS development
 help / color / mirror / Atom feed
From: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
To: users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org,
	jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org
Cc: konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org
Subject: Re: [PATCH 0/2] nilfs2: using nobarrier option instead of barrier=off
Date: Wed, 11 Nov 2009 21:03:52 +0900 (JST)	[thread overview]
Message-ID: <20091111.210352.22528384.ryusuke@osrg.net> (raw)
In-Reply-To: <1257930258-3106-1-git-send-email-jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>

Hi!
On Wed, 11 Nov 2009 18:04:16 +0900, Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org> wrote:
> Hi,
> 
> This is a series of patches to use nobarrier mount option
> instead of barrier=off, for most of fs using nofoobar style option.
> 
> First patch is the actual patch to modify the mount option.
> 
> Second patch is cleanup patch to remove unused match_bool() function
> as a result of modifying mount option.
> 
>  fs/nilfs2/super.c |   28 +++++-----------------------
>  1 files changed, 5 insertions(+), 23 deletions(-)

Well, this change looks quite reasonable, and also helps to resolve
the discordance between the old barrier option and standard linux
options; it also matches the "-o norepair" which I posted recently.

Although the first patch changes user-interface, I believe the impact
is limited because the barrier feature is enabled by default.

So, I'd like to apply your change unless someone dissents.

Sekiba-san, could you modify Documentation/filesystems/nilfs2.txt and
include it in the first patch?

The doc file has description on mount options.

Thanks,
Ryusuke Konishi

  parent reply	other threads:[~2009-11-11 12:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11  9:04 [PATCH 0/2] nilfs2: using nobarrier option instead of barrier=off Jiro SEKIBA
     [not found] ` <1257930258-3106-1-git-send-email-jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
2009-11-11  9:04   ` [PATCH 1/2] nilfs2: Using " Jiro SEKIBA
2009-11-11  9:04   ` [PATCH 2/2] nilfs2: cleanup unused match_bool function Jiro SEKIBA
2009-11-11 12:03   ` Ryusuke Konishi [this message]
     [not found]     ` <20091111.210352.22528384.ryusuke-sG5X7nlA6pw@public.gmane.org>
2009-11-12  3:51       ` [PATCH 0/2] nilfs2: using nobarrier option instead of barrier=off Jiro SEKIBA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091111.210352.22528384.ryusuke@osrg.net \
    --to=ryusuke-sg5x7nla6pw@public.gmane.org \
    --cc=jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org \
    --cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
    --cc=users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox