Re: pp (protection period) mount option

[Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>]

Hi,
On Sat, 28 Nov 2009 22:16:31 +0100, David Smid <david-0RIiUExYzkzCfDggNXIi3w@public.gmane.org>
wrote:
> Thanks you for your valuable comments.
> 
> You are right, of course. No kernel code changes are needed.
> Here is my take #2.
> 
> David

Thank you, David.  I reviewed the patch in detail, and no worrisome
point found.

During tests, I noticed that remount doesn't work for this option:

  For instance, after doing

  # mount -t nilfs2 -o pp=3D600 /dev/sdb1 /test

  and

  # mount -t nilfs2 -o remount,pp=3D400 /dev/sdb1 /test

  then, a cleanerd with "-p 600" was still working.

I think usually this doesn't make trouble, but I'd like to hear your
opinion before merging.  If you want to revise the issue to keep
semantics of remount option, I will wait for you.

If you don't care, I will merge the patch as is.

Thanks,
Ryusuke Konishi