From: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
To: users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org,
tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org
Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org
Subject: Re: [PATCH 02/12] nilfs2: Storage class should be before const qualifier
Date: Wed, 23 Dec 2009 23:55:59 +0900 (JST) [thread overview]
Message-ID: <20091223.235559.25155531.ryusuke@osrg.net> (raw)
In-Reply-To: <1261573067-8673-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
On Wed, 23 Dec 2009 13:57:47 +0100, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
Applied. Thank you!
Ryusuke Konishi
> ---
> fs/nilfs2/ioctl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
> index f6af760..d6b2b83 100644
> --- a/fs/nilfs2/ioctl.c
> +++ b/fs/nilfs2/ioctl.c
> @@ -480,7 +480,7 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp,
> unsigned int cmd, void __user *argp)
> {
> struct nilfs_argv argv[5];
> - const static size_t argsz[5] = {
> + static const size_t argsz[5] = {
> sizeof(struct nilfs_vdesc),
> sizeof(struct nilfs_period),
> sizeof(__u64),
> --
> 1.6.3.3
On Wed, 23 Dec 2009 14:01:05 +0100, Tobias Klauser wrote:
> > Subject: Re: [PATCH 02/12] nilfs2: Storage class should be before const
> > qualifier
>
> Sorry, this should jsut have been [PATCH], not [PATCH 02/12]. The
> remaining patches are not targeted at nilfs.
>
> Cheers, Tobias
prev parent reply other threads:[~2009-12-23 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 12:57 [PATCH 02/12] nilfs2: Storage class should be before const qualifier Tobias Klauser
[not found] ` <1261573067-8673-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
2009-12-23 13:01 ` Tobias Klauser
2009-12-23 14:55 ` Ryusuke Konishi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223.235559.25155531.ryusuke@osrg.net \
--to=ryusuke-sg5x7nla6pw@public.gmane.org \
--cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
--cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org \
--cc=users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox