Linux NILFS development
 help / color / mirror / Atom feed
From: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
To: jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org
Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org
Subject: Re: [PATCH] mount.nilfs2: add "uhelper=" option
Date: Fri, 23 Jul 2010 23:33:10 +0900 (JST)	[thread overview]
Message-ID: <20100723.233310.85394061.ryusuke@osrg.net> (raw)
In-Reply-To: <87d3ueej51.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>

On Fri, 23 Jul 2010 16:45:30 +0900, Jiro SEKIBA wrote:
> 
> Standard mount command takes uhelper=<helper_name> option to tell the mount
> is under <helper_name> control.  When this option is specified,
> umount.<helper_name> is called on unmount time.
> 
> This option is used when mount is triggered by udisks. udisks is a dbus
> service daemon.  The service is used by Palimpsest.  To controll nilfs2
> partition from palimpsest, interpret the option is required.
>
> Signed-off-by: Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
> ---

Very interesting.  If nilfs becomes available on Palimsest, it will
make levels of entry lower.

I took this one and applied to nilfs-utils.git.
If you need any additional help for this, please let me know.

BTW, I didn't know the role of the struct string_opt_map until now.
It looks helpful also for other virtual options.

Thanks,
Ryusuke Konishi

>  sbin/mount/mount_opts.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/sbin/mount/mount_opts.c b/sbin/mount/mount_opts.c
> index 9db599f..396b41f 100644
> --- a/sbin/mount/mount_opts.c
> +++ b/sbin/mount/mount_opts.c
> @@ -98,7 +98,7 @@ static const struct opt_map opt_map[] = {
>  };
>  
>  static const char *opt_loopdev, *opt_vfstype, *opt_offset, *opt_encryption,
> -	*opt_speed, *opt_comment;
> +	*opt_speed, *opt_comment, *opt_uhelper;
>  
>  static struct string_opt_map {
>  	char *tag;
> @@ -111,6 +111,7 @@ static struct string_opt_map {
>  	{ "encryption=", 0, &opt_encryption },
>  	{ "speed=", 0, &opt_speed },
>  	{ "comment=", 1, &opt_comment },
> +	{ "uhelper=", 0, &opt_uhelper },
>  	{ NULL, 0, NULL }
>  };
>  
> -- 
> 1.5.6.5
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

       reply	other threads:[~2010-07-23 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87d3ueej51.wl%jir@sekiba.com>
     [not found] ` <87d3ueej51.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2010-07-23 14:33   ` Ryusuke Konishi [this message]
2010-07-23  7:37 [PATCH] mount.nilfs2: add "uhelper=" option Jiro SEKIBA
     [not found] ` <876306y7ha.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2010-07-23  7:42   ` Jiro SEKIBA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100723.233310.85394061.ryusuke@osrg.net \
    --to=ryusuke-sg5x7nla6pw@public.gmane.org \
    --cc=jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org \
    --cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
    --cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox