Linux NILFS development
 help / color / mirror / Atom feed
From: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
To: jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org
Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org
Subject: Re: [PATCH] nilfs2-utils: fix bug when opening non-nilfs2 device
Date: Sat, 11 Sep 2010 14:57:06 +0900 (JST)	[thread overview]
Message-ID: <20100911.145706.55860795.ryusuke@osrg.net> (raw)
In-Reply-To: <87vd6ec596.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>

On Fri, 10 Sep 2010 18:33:25 +0900, Jiro SEKIBA wrote:
> Hi,
> 
> This patch fixes a wrong return value of nilfs_sb_read when opening
> non-nilfs2 device.  nilfs_sb_read should return NULL in case it was
> not a nilfs2 device instead of "-1" to indicate error.
> 
> Signed-off-by: Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>

Applied, thank you.

Ryusuke Konishi

> ---
>  lib/sb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/sb.c b/lib/sb.c
> index 201b9ad..b60575d 100644
> --- a/lib/sb.c
> +++ b/lib/sb.c
> @@ -161,7 +161,7 @@ struct nilfs_super_block *nilfs_sb_read(int devfd)
>  	struct nilfs_super_block *sbp[2];
>  
>  	if (__nilfs_sb_read(devfd, sbp, NULL))
> -		return -1;
> +		return NULL;
>  
>  	if (!sbp[0]) {
>  		sbp[0] = sbp[1];
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2010-09-11  5:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10  9:33 [PATCH] nilfs2-utils: fix bug when opening non-nilfs2 device Jiro SEKIBA
     [not found] ` <87vd6ec596.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2010-09-11  5:57   ` Ryusuke Konishi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100911.145706.55860795.ryusuke@osrg.net \
    --to=ryusuke-sg5x7nla6pw@public.gmane.org \
    --cc=jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org \
    --cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
    --cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox