* BUG: unable to handle kernel NULL pointer dereference at 00000048
@ 2012-02-29 14:31 Slicky Devil
[not found] ` <CAMRzUtxbOXWOyZ1wMRmxSsRs67FoDq_hf7Pg_UrAi4P=DnhqsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Slicky Devil @ 2012-02-29 14:31 UTC (permalink / raw)
To: linux-nilfs-u79uwXL29TY76Z2rM5mHXA
Hello!
I think I found a bug for you, guys.
The situation was as following. At first, I set up LVM with a single
lv (with nilfs) for root. Everything worked fine. Then I decided to
create a separate home partition. I shrank the root a bit, created
another nilfs logical volume for home. Then I shrank root/expanded
home a couple of times. In the end I got the bug, when tried to mount
the home.
I'm pretty much confident (say 90%) that I didn't mess things up by
shrinking a partition before resizing the appropriate filesystem.
Now every time I try to mount home I get the following:
[ 1367.830334] BUG: unable to handle kernel NULL pointer dereference at 00000048
[ 1367.831581] IP: [<d0d7a08e>] nilfs_load_super_block+0x17e/0x280 [nilfs2]
[ 1367.832098] *pde = 00000000
[ 1367.832596] Oops: 0000 [#1] PREEMPT SMP
[ 1367.833098] Modules linked in: ext2 mbcache snd_intel8x0 e1000
ppdev snd_ac97_codec ac97_bus snd_pcm snd_page_alloc vboxvideo(O)
snd_timer drm snd agpgart parport_pc soundcore parport i2c_piix4
i2c_core serio_raw psmouse pcspkr evdev joydev processor ac button
vboxsf(O) vboxguest(O) nilfs2 dm_mod sr_mod cdrom sd_mod usbhid hid
ahci libahci libata ohci_hcd scsi_mod usbcore usb_common
[ 1367.833562]
[ 1367.833562] Pid: 710, comm: mount.nilfs2 Tainted: G O
3.2.6-2-ARCH #1 innotek GmbH VirtualBox
[ 1367.833562] EIP: 0060:[<d0d7a08e>] EFLAGS: 00010202 CPU: 0
[ 1367.833562] EIP is at nilfs_load_super_block+0x17e/0x280 [nilfs2]
[ 1367.833562] EAX: c9cb6400 EBX: ce845e00 ECX: 00000000 EDX: 00000000
[ 1367.833562] ESI: 00000001 EDI: 00000000 EBP: ca9bbe08 ESP: ca9bbdcc
[ 1367.833562] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
[ 1367.833562] Process mount.nilfs2 (pid: 710, ti=ca9ba000
task=cf054d20 task.ti=ca9ba000)
[ 1367.833562] Stack:
[ 1367.833562] 00000400 ce845e1c 0013f800 00000000 00000000 00000000
cc7d6c00 00000400
[ 1367.833562] 00000001 00000001 00000001 00000001 ce845e00 ca9bbe30
cc7d6c00 ca9bbe40
[ 1367.833562] d0d7a87b ca9bbe30 00000114 000080d0 00000200 00034460
cc7d6db0 00000000
[ 1367.833562] Call Trace:
[ 1367.833562] [<d0d7a87b>] init_nilfs+0x4b/0x2e0 [nilfs2]
[ 1367.833562] [<d0d6f707>] nilfs_mount+0x447/0x5b0 [nilfs2]
[ 1367.833562] [<c01f33a4>] ? pcpu_alloc+0x714/0x810
[ 1367.833562] [<c02d2add>] ? ida_get_new_above+0x1ad/0x230
[ 1367.833562] [<c02d2add>] ? ida_get_new_above+0x1ad/0x230
[ 1367.833562] [<c0226636>] mount_fs+0x36/0x180
[ 1367.833562] [<c01f34af>] ? __alloc_percpu+0xf/0x20
[ 1367.833562] [<c023d961>] vfs_kern_mount+0x51/0xa0
[ 1367.833562] [<c023ddae>] do_kern_mount+0x3e/0xe0
[ 1367.833562] [<c023f189>] do_mount+0x169/0x700
[ 1367.833562] [<c01eeb29>] ? strndup_user+0x49/0x70
[ 1367.833562] [<c023fa9b>] sys_mount+0x6b/0xa0
[ 1367.833562] [<c04abd1f>] sysenter_do_call+0x12/0x28
[ 1367.833562] Code: 53 18 8b 43 20 89 4b 18 8b 4b 24 89 53 1c 89 43
24 89 4b 20 8b 43 20 c7 43 2c 00 00 00 00 23 75 e8 8b 50 68 89 53 28
8b 54 b3 20 <8b> 72 48 8b 7a 4c 8b 55 08 89 b3 84 00 00 00 89 bb 88 00
00 00
[ 1367.833562] EIP: [<d0d7a08e>] nilfs_load_super_block+0x17e/0x280
[nilfs2] SS:ESP 0068:ca9bbdcc
[ 1367.833562] CR2: 0000000000000048
[ 1367.855410] ---[ end trace 0b5fed15fa08cff2 ]---
The kernel is the standard archlinux "stocK" kernel run within
virtualbox: Linux arch1 3.2.6-2-ARCH #1 SMP PREEMPT Thu Feb 16
10:23:00 UTC 2012 i686 Intel(R) Core(TM) i5 CPU 650 @ 3.20GHz
GenuineIntel GNU/Linux
I can provide the partition superblock, if necessary.
Cheers!
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread[parent not found: <CAMRzUtxbOXWOyZ1wMRmxSsRs67FoDq_hf7Pg_UrAi4P=DnhqsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: BUG: unable to handle kernel NULL pointer dereference at 00000048 [not found] ` <CAMRzUtxbOXWOyZ1wMRmxSsRs67FoDq_hf7Pg_UrAi4P=DnhqsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2012-03-05 14:30 ` Ryusuke Konishi [not found] ` <20120305.233028.248350005.ryusuke-sG5X7nlA6pw@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Ryusuke Konishi @ 2012-03-05 14:30 UTC (permalink / raw) To: slicky.dvl-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA Hi, On Wed, 29 Feb 2012 17:31:18 +0300, Slicky Devil wrote: > Hello! > > I think I found a bug for you, guys. > > The situation was as following. At first, I set up LVM with a single > lv (with nilfs) for root. Everything worked fine. Then I decided to > create a separate home partition. I shrank the root a bit, created > another nilfs logical volume for home. Then I shrank root/expanded > home a couple of times. In the end I got the bug, when tried to mount > the home. > > I'm pretty much confident (say 90%) that I didn't mess things up by > shrinking a partition before resizing the appropriate filesystem. > > Now every time I try to mount home I get the following: > > [ 1367.830334] BUG: unable to handle kernel NULL pointer dereference at 00000048 > [ 1367.831581] IP: [<d0d7a08e>] nilfs_load_super_block+0x17e/0x280 [nilfs2] > [ 1367.832098] *pde = 00000000 > [ 1367.832596] Oops: 0000 [#1] PREEMPT SMP > [ 1367.833098] Modules linked in: ext2 mbcache snd_intel8x0 e1000 > ppdev snd_ac97_codec ac97_bus snd_pcm snd_page_alloc vboxvideo(O) > snd_timer drm snd agpgart parport_pc soundcore parport i2c_piix4 > i2c_core serio_raw psmouse pcspkr evdev joydev processor ac button > vboxsf(O) vboxguest(O) nilfs2 dm_mod sr_mod cdrom sd_mod usbhid hid > ahci libahci libata ohci_hcd scsi_mod usbcore usb_common > [ 1367.833562] > [ 1367.833562] Pid: 710, comm: mount.nilfs2 Tainted: G O > 3.2.6-2-ARCH #1 innotek GmbH VirtualBox > [ 1367.833562] EIP: 0060:[<d0d7a08e>] EFLAGS: 00010202 CPU: 0 > [ 1367.833562] EIP is at nilfs_load_super_block+0x17e/0x280 [nilfs2] > [ 1367.833562] EAX: c9cb6400 EBX: ce845e00 ECX: 00000000 EDX: 00000000 > [ 1367.833562] ESI: 00000001 EDI: 00000000 EBP: ca9bbe08 ESP: ca9bbdcc > [ 1367.833562] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 > [ 1367.833562] Process mount.nilfs2 (pid: 710, ti=ca9ba000 > task=cf054d20 task.ti=ca9ba000) > [ 1367.833562] Stack: > [ 1367.833562] 00000400 ce845e1c 0013f800 00000000 00000000 00000000 > cc7d6c00 00000400 > [ 1367.833562] 00000001 00000001 00000001 00000001 ce845e00 ca9bbe30 > cc7d6c00 ca9bbe40 > [ 1367.833562] d0d7a87b ca9bbe30 00000114 000080d0 00000200 00034460 > cc7d6db0 00000000 > [ 1367.833562] Call Trace: > [ 1367.833562] [<d0d7a87b>] init_nilfs+0x4b/0x2e0 [nilfs2] > [ 1367.833562] [<d0d6f707>] nilfs_mount+0x447/0x5b0 [nilfs2] > [ 1367.833562] [<c01f33a4>] ? pcpu_alloc+0x714/0x810 > [ 1367.833562] [<c02d2add>] ? ida_get_new_above+0x1ad/0x230 > [ 1367.833562] [<c02d2add>] ? ida_get_new_above+0x1ad/0x230 > [ 1367.833562] [<c0226636>] mount_fs+0x36/0x180 > [ 1367.833562] [<c01f34af>] ? __alloc_percpu+0xf/0x20 > [ 1367.833562] [<c023d961>] vfs_kern_mount+0x51/0xa0 > [ 1367.833562] [<c023ddae>] do_kern_mount+0x3e/0xe0 > [ 1367.833562] [<c023f189>] do_mount+0x169/0x700 > [ 1367.833562] [<c01eeb29>] ? strndup_user+0x49/0x70 > [ 1367.833562] [<c023fa9b>] sys_mount+0x6b/0xa0 > [ 1367.833562] [<c04abd1f>] sysenter_do_call+0x12/0x28 > [ 1367.833562] Code: 53 18 8b 43 20 89 4b 18 8b 4b 24 89 53 1c 89 43 > 24 89 4b 20 8b 43 20 c7 43 2c 00 00 00 00 23 75 e8 8b 50 68 89 53 28 > 8b 54 b3 20 <8b> 72 48 8b 7a 4c 8b 55 08 89 b3 84 00 00 00 89 bb 88 00 > 00 00 > [ 1367.833562] EIP: [<d0d7a08e>] nilfs_load_super_block+0x17e/0x280 > [nilfs2] SS:ESP 0068:ca9bbdcc > [ 1367.833562] CR2: 0000000000000048 > [ 1367.855410] ---[ end trace 0b5fed15fa08cff2 ]--- > > The kernel is the standard archlinux "stocK" kernel run within > virtualbox: Linux arch1 3.2.6-2-ARCH #1 SMP PREEMPT Thu Feb 16 > 10:23:00 UTC 2012 i686 Intel(R) Core(TM) i5 CPU 650 @ 3.20GHz > GenuineIntel GNU/Linux > > I can provide the partition superblock, if necessary. Thank you for reporting this issue. I found a bug in the nilfs_load_super_block function which has potential to cause this oops. Could you try the following patch if you still have the partition ? Thanks, Ryusuke Konishi diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c index d327140..35a8970 100644 --- a/fs/nilfs2/the_nilfs.c +++ b/fs/nilfs2/the_nilfs.c @@ -515,6 +515,7 @@ static int nilfs_load_super_block(struct the_nilfs *nilfs, brelse(sbh[1]); sbh[1] = NULL; sbp[1] = NULL; + valid[1] = 0; swp = 0; } if (!valid[swp]) { -- 1.7.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <20120305.233028.248350005.ryusuke-sG5X7nlA6pw@public.gmane.org>]
* Re: BUG: unable to handle kernel NULL pointer dereference at 00000048 [not found] ` <20120305.233028.248350005.ryusuke-sG5X7nlA6pw@public.gmane.org> @ 2012-03-05 15:33 ` Ryusuke Konishi 2012-03-06 13:24 ` Slicky Devil 1 sibling, 0 replies; 7+ messages in thread From: Ryusuke Konishi @ 2012-03-05 15:33 UTC (permalink / raw) To: slicky.dvl-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA On Mon, 05 Mar 2012 23:30:28 +0900 (JST), Ryusuke Konishi wrote: > Hi, > On Wed, 29 Feb 2012 17:31:18 +0300, Slicky Devil wrote: > > Hello! > > > > I think I found a bug for you, guys. > > > > The situation was as following. At first, I set up LVM with a single > > lv (with nilfs) for root. Everything worked fine. Then I decided to > > create a separate home partition. I shrank the root a bit, created > > another nilfs logical volume for home. Then I shrank root/expanded > > home a couple of times. In the end I got the bug, when tried to mount > > the home. > > > > I'm pretty much confident (say 90%) that I didn't mess things up by > > shrinking a partition before resizing the appropriate filesystem. > > > > Now every time I try to mount home I get the following: > > > > [ 1367.830334] BUG: unable to handle kernel NULL pointer dereference at 00000048 > > [ 1367.831581] IP: [<d0d7a08e>] nilfs_load_super_block+0x17e/0x280 [nilfs2] > > [ 1367.832098] *pde = 00000000 > > [ 1367.832596] Oops: 0000 [#1] PREEMPT SMP > > [ 1367.833098] Modules linked in: ext2 mbcache snd_intel8x0 e1000 > > ppdev snd_ac97_codec ac97_bus snd_pcm snd_page_alloc vboxvideo(O) > > snd_timer drm snd agpgart parport_pc soundcore parport i2c_piix4 > > i2c_core serio_raw psmouse pcspkr evdev joydev processor ac button > > vboxsf(O) vboxguest(O) nilfs2 dm_mod sr_mod cdrom sd_mod usbhid hid > > ahci libahci libata ohci_hcd scsi_mod usbcore usb_common > > [ 1367.833562] > > [ 1367.833562] Pid: 710, comm: mount.nilfs2 Tainted: G O > > 3.2.6-2-ARCH #1 innotek GmbH VirtualBox > > [ 1367.833562] EIP: 0060:[<d0d7a08e>] EFLAGS: 00010202 CPU: 0 > > [ 1367.833562] EIP is at nilfs_load_super_block+0x17e/0x280 [nilfs2] > > [ 1367.833562] EAX: c9cb6400 EBX: ce845e00 ECX: 00000000 EDX: 00000000 > > [ 1367.833562] ESI: 00000001 EDI: 00000000 EBP: ca9bbe08 ESP: ca9bbdcc > > [ 1367.833562] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 > > [ 1367.833562] Process mount.nilfs2 (pid: 710, ti=ca9ba000 > > task=cf054d20 task.ti=ca9ba000) > > [ 1367.833562] Stack: > > [ 1367.833562] 00000400 ce845e1c 0013f800 00000000 00000000 00000000 > > cc7d6c00 00000400 > > [ 1367.833562] 00000001 00000001 00000001 00000001 ce845e00 ca9bbe30 > > cc7d6c00 ca9bbe40 > > [ 1367.833562] d0d7a87b ca9bbe30 00000114 000080d0 00000200 00034460 > > cc7d6db0 00000000 > > [ 1367.833562] Call Trace: > > [ 1367.833562] [<d0d7a87b>] init_nilfs+0x4b/0x2e0 [nilfs2] > > [ 1367.833562] [<d0d6f707>] nilfs_mount+0x447/0x5b0 [nilfs2] > > [ 1367.833562] [<c01f33a4>] ? pcpu_alloc+0x714/0x810 > > [ 1367.833562] [<c02d2add>] ? ida_get_new_above+0x1ad/0x230 > > [ 1367.833562] [<c02d2add>] ? ida_get_new_above+0x1ad/0x230 > > [ 1367.833562] [<c0226636>] mount_fs+0x36/0x180 > > [ 1367.833562] [<c01f34af>] ? __alloc_percpu+0xf/0x20 > > [ 1367.833562] [<c023d961>] vfs_kern_mount+0x51/0xa0 > > [ 1367.833562] [<c023ddae>] do_kern_mount+0x3e/0xe0 > > [ 1367.833562] [<c023f189>] do_mount+0x169/0x700 > > [ 1367.833562] [<c01eeb29>] ? strndup_user+0x49/0x70 > > [ 1367.833562] [<c023fa9b>] sys_mount+0x6b/0xa0 > > [ 1367.833562] [<c04abd1f>] sysenter_do_call+0x12/0x28 > > [ 1367.833562] Code: 53 18 8b 43 20 89 4b 18 8b 4b 24 89 53 1c 89 43 > > 24 89 4b 20 8b 43 20 c7 43 2c 00 00 00 00 23 75 e8 8b 50 68 89 53 28 > > 8b 54 b3 20 <8b> 72 48 8b 7a 4c 8b 55 08 89 b3 84 00 00 00 89 bb 88 00 > > 00 00 > > [ 1367.833562] EIP: [<d0d7a08e>] nilfs_load_super_block+0x17e/0x280 > > [nilfs2] SS:ESP 0068:ca9bbdcc > > [ 1367.833562] CR2: 0000000000000048 > > [ 1367.855410] ---[ end trace 0b5fed15fa08cff2 ]--- > > > > The kernel is the standard archlinux "stocK" kernel run within > > virtualbox: Linux arch1 3.2.6-2-ARCH #1 SMP PREEMPT Thu Feb 16 > > 10:23:00 UTC 2012 i686 Intel(R) Core(TM) i5 CPU 650 @ 3.20GHz > > GenuineIntel GNU/Linux > > > > I can provide the partition superblock, if necessary. > > Thank you for reporting this issue. > > I found a bug in the nilfs_load_super_block function which has > potential to cause this oops. Here is a further note on the oops. According to your log, the oops looks to be caused by an access to a structure member located at the offset of 48 hex bytes from the head of super block (and the pointer to the super block was NULL). > BUG: unable to handle kernel NULL pointer dereference at 00000048 The member is 's_last_seq', and its only referrer in nilfs_load_super_block function is the following line: nilfs->ns_prot_seq = le64_to_cpu(sbp[valid[1] & !swp]->s_last_seq); where sbp[] is the array of pointers to super blocks. Thus, either valid[1] or swp seemed to be wrong, and my assumption is valid[1] was not properly set to zero by the following defect. Ryusuke Konishi > Could you try the following patch if you still have the partition ? > > > Thanks, > Ryusuke Konishi > > diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c > index d327140..35a8970 100644 > --- a/fs/nilfs2/the_nilfs.c > +++ b/fs/nilfs2/the_nilfs.c > @@ -515,6 +515,7 @@ static int nilfs_load_super_block(struct the_nilfs *nilfs, > brelse(sbh[1]); > sbh[1] = NULL; > sbp[1] = NULL; > + valid[1] = 0; > swp = 0; > } > if (!valid[swp]) { > -- > 1.7.7.4 > -- > To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: BUG: unable to handle kernel NULL pointer dereference at 00000048 [not found] ` <20120305.233028.248350005.ryusuke-sG5X7nlA6pw@public.gmane.org> 2012-03-05 15:33 ` Ryusuke Konishi @ 2012-03-06 13:24 ` Slicky Devil [not found] ` <CAMRzUtwpZQ_ZmZoGzOA0wkmTVQKVJRwA7OB3X_ktRXPj9MJoXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 1 sibling, 1 reply; 7+ messages in thread From: Slicky Devil @ 2012-03-06 13:24 UTC (permalink / raw) To: Ryusuke Konishi; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA Luckily, I seem to have been able to reproduce the bug (after shrinking the partition down to some hundred MB). Your patch seems to have fixed it! Now I get the following, which, I think, is pretty much expected, since I chopped a large part of the filesystem off: 15:52 root ~ # mount /dev/1/buggy-home test [ 461.137823] NILFS: error searching super root. mount.nilfs2: Error while mounting /dev/mapper/1-buggy--home on /root/test: Input/output error Please, fix the bug in the official kernel sources, too. Your filesystem proved very useful here for storing documents and other changeable stuff -- we don't want it get broken unexpectedly. :) Still, thanks a lot! The things you are doing here are really cool! Cheers! On Mon, Mar 5, 2012 at 5:30 PM, Ryusuke Konishi <konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org> wrote: > > Thank you for reporting this issue. > > I found a bug in the nilfs_load_super_block function which has > potential to cause this oops. > > Could you try the following patch if you still have the partition ? > > > Thanks, > Ryusuke Konishi > > diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c > index d327140..35a8970 100644 > --- a/fs/nilfs2/the_nilfs.c > +++ b/fs/nilfs2/the_nilfs.c > @@ -515,6 +515,7 @@ static int nilfs_load_super_block(struct the_nilfs *nilfs, > brelse(sbh[1]); > sbh[1] = NULL; > sbp[1] = NULL; > + valid[1] = 0; > swp = 0; > } > if (!valid[swp]) { > -- > 1.7.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CAMRzUtwpZQ_ZmZoGzOA0wkmTVQKVJRwA7OB3X_ktRXPj9MJoXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: BUG: unable to handle kernel NULL pointer dereference at 00000048 [not found] ` <CAMRzUtwpZQ_ZmZoGzOA0wkmTVQKVJRwA7OB3X_ktRXPj9MJoXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2012-03-06 14:54 ` Ryusuke Konishi [not found] ` <20120306.235404.52180631.ryusuke-sG5X7nlA6pw@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Ryusuke Konishi @ 2012-03-06 14:54 UTC (permalink / raw) To: slicky.dvl-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA Hi, On Tue, 6 Mar 2012 16:24:40 +0300, Slicky Devil wrote: > Luckily, I seem to have been able to reproduce the bug (after > shrinking the partition down to some hundred MB). Your patch seems to > have fixed it! > > Now I get the following, which, I think, is pretty much expected, > since I chopped a large part of the filesystem off: > > 15:52 root ~ # mount /dev/1/buggy-home test > [ 461.137823] NILFS: error searching super root. > mount.nilfs2: Error while mounting /dev/mapper/1-buggy--home on > /root/test: Input/output error Hmmm. Did you shrink the filesystem with nilfs-resize tool before shrinking the partition ? This error (I/O error) also looks undesirable to me. > Please, fix the bug in the official kernel sources, too. Your > filesystem proved very useful here for storing documents and other > changeable stuff -- we don't want it get broken unexpectedly. :) Sure, I will send the fix upstream (and stable trees). Thanks, Ryusuke Konishi > Still, thanks a lot! The things you are doing here are really cool! > > Cheers! > > > > On Mon, Mar 5, 2012 at 5:30 PM, Ryusuke Konishi > <konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org> wrote: > > > > Thank you for reporting this issue. > > > > I found a bug in the nilfs_load_super_block function which has > > potential to cause this oops. > > > > Could you try the following patch if you still have the partition ? > > > > > > Thanks, > > Ryusuke Konishi > > > > diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c > > index d327140..35a8970 100644 > > --- a/fs/nilfs2/the_nilfs.c > > +++ b/fs/nilfs2/the_nilfs.c > > @@ -515,6 +515,7 @@ static int nilfs_load_super_block(struct the_nilfs *nilfs, > > brelse(sbh[1]); > > sbh[1] = NULL; > > sbp[1] = NULL; > > + valid[1] = 0; > > swp = 0; > > } > > if (!valid[swp]) { > > -- > > 1.7.7.4 > -- > To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20120306.235404.52180631.ryusuke-sG5X7nlA6pw@public.gmane.org>]
* Re: BUG: unable to handle kernel NULL pointer dereference at 00000048 [not found] ` <20120306.235404.52180631.ryusuke-sG5X7nlA6pw@public.gmane.org> @ 2012-03-06 21:07 ` Slicky Devil [not found] ` <CAMRzUtyoYPzCYhqaxughGOBWr_iUcFyOx5p1eBYJRa19xq8Xgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Slicky Devil @ 2012-03-06 21:07 UTC (permalink / raw) To: Ryusuke Konishi; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA On Tue, Mar 6, 2012 at 5:54 PM, Ryusuke Konishi <konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org> wrote: > Hmmm. Did you shrink the filesystem with nilfs-resize tool > before shrinking the partition ? > > This error (I/O error) also looks undesirable to me. I couldn't shrink the filesystem, because I couldn't mount it because of the bug. The filesystem was large and I was in desparate need of some spare diskspace. At first, I was going to completely get rid of it, but then I thought you might want to have a look at the superblock, or some othe block, or whatever else to analyze the bug. Since the bug was some sort of initialization issue, I finally decided to keep the first 500 MB of the filesystem and reclaimed the rest of it (by shrinking the partition). And all that had happened *before* I posted the bug report on this mailing list. Luckily, when I tried to mount the "broken" filesystem today, the nilfs driver exposed the very same oops again. I applied your patch/recompiled the kernel and the oops disappeared. So, no. I didn't use any nilfs-resize. And those IO error are pretty much expected to me. -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CAMRzUtyoYPzCYhqaxughGOBWr_iUcFyOx5p1eBYJRa19xq8Xgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: BUG: unable to handle kernel NULL pointer dereference at 00000048 [not found] ` <CAMRzUtyoYPzCYhqaxughGOBWr_iUcFyOx5p1eBYJRa19xq8Xgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2012-03-10 3:08 ` Ryusuke Konishi 0 siblings, 0 replies; 7+ messages in thread From: Ryusuke Konishi @ 2012-03-10 3:08 UTC (permalink / raw) To: slicky.dvl-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA On Wed, 7 Mar 2012 00:07:24 +0300, Slicky Devil wrote: > On Tue, Mar 6, 2012 at 5:54 PM, Ryusuke Konishi > <konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org> wrote: > > Hmmm. Did you shrink the filesystem with nilfs-resize tool > > before shrinking the partition ? > > > > This error (I/O error) also looks undesirable to me. > > I couldn't shrink the filesystem, because I couldn't mount it because > of the bug. The filesystem was large and I was in desparate need of > some spare diskspace. At first, I was going to completely get rid of > it, but then I thought you might want to have a look at the > superblock, or some othe block, or whatever else to analyze the bug. > Since the bug was some sort of initialization issue, I finally decided > to keep the first 500 MB of the filesystem and reclaimed the rest of > it (by shrinking the partition). > > And all that had happened *before* I posted the bug report on this mailing list. > > Luckily, when I tried to mount the "broken" filesystem today, the > nilfs driver exposed the very same oops again. I applied your > patch/recompiled the kernel and the oops disappeared. > > So, no. I didn't use any nilfs-resize. And those IO error are pretty > much expected to me. Understood, thank you for letting me know the situation. Regards, Ryusuke Konishi -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-03-10 3:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-29 14:31 BUG: unable to handle kernel NULL pointer dereference at 00000048 Slicky Devil
[not found] ` <CAMRzUtxbOXWOyZ1wMRmxSsRs67FoDq_hf7Pg_UrAi4P=DnhqsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-05 14:30 ` Ryusuke Konishi
[not found] ` <20120305.233028.248350005.ryusuke-sG5X7nlA6pw@public.gmane.org>
2012-03-05 15:33 ` Ryusuke Konishi
2012-03-06 13:24 ` Slicky Devil
[not found] ` <CAMRzUtwpZQ_ZmZoGzOA0wkmTVQKVJRwA7OB3X_ktRXPj9MJoXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-06 14:54 ` Ryusuke Konishi
[not found] ` <20120306.235404.52180631.ryusuke-sG5X7nlA6pw@public.gmane.org>
2012-03-06 21:07 ` Slicky Devil
[not found] ` <CAMRzUtyoYPzCYhqaxughGOBWr_iUcFyOx5p1eBYJRa19xq8Xgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-10 3:08 ` Ryusuke Konishi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).