From: Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
To: Ryusuke Konishi
<konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC] simplifying the "is it mounted" checks for nilfs2
Date: Sat, 6 Jul 2013 00:33:35 +0100 [thread overview]
Message-ID: <20130705233335.GV4165@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130705220309.GU4165-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
On Fri, Jul 05, 2013 at 11:03:09PM +0100, Al Viro wrote:
> Do you see any problems with just giving nilfs ->drop_inode() instance
> like this:
> int nilfs2_drop_inode(struct inode *inode)
> {
> if (unlikely(inode->i_ino == NILFS_ROOT_INO))
> return true;
> return generic_drop_inode(inode);
> }
> Then nilfs_root will live exactly until we unmount the damn thing, giving us
... except that it won't be enough ;-/ Nothing to kick dentries out
on such ummount of a secondary. Oh, well... I still doubt that
have_submounts() makes any sense there, but...
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-07-05 23:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 22:03 [RFC] simplifying the "is it mounted" checks for nilfs2 Al Viro
[not found] ` <20130705220309.GU4165-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2013-07-05 23:33 ` Al Viro [this message]
2013-07-06 8:56 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130705233335.GV4165@ZenIV.linux.org.uk \
--to=viro-3bdd1+5odreifsdqtta3olvcufugdwfn@public.gmane.org \
--cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox