From: Andrew Morton <akpm@linux-foundation.org>
To: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>,
DanCarpenter <dan.carpenter@oracle.com>,
linux-nilfs@vger.kernel.org,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
Date: Wed, 14 Aug 2013 16:00:01 -0700 [thread overview]
Message-ID: <20130814160001.3fa9e4dabb7dca81dab31e87@linux-foundation.org> (raw)
In-Reply-To: <20130814.015148.316894835.konishi.ryusuke@lab.ntt.co.jp>
On Wed, 14 Aug 2013 01:51:48 +0900 (JST) Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> wrote:
> On Tue, 13 Aug 2013 17:50:33 +0400, Vyacheslav Dubeyko wrote:
> > From: Vyacheslav Dubeyko <slava@dubeyko.com>
> > Subject: [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
> >
> > This patch removes double call of bio_put() in nilfs_end_bio_write()
> > for the case of BIO_EOPNOTSUPP error detection. The issue was found
> > by Dan Carpenter and he suggests first version of the fix too.
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
> > CC: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
>
> Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
> Tested-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
>
> I tested this patch by inserting a pseudo EOPNOTSUPP error, and this
> actually fixed a crach "kernel BUG at fs/bio.c:498!" due to reference
> count underflow of bio_put() that nilfs_end_bio_write() induced.
>
>
> Andrew, please pick up this bug-fix preferably for this cycle.
Should we apply the fix to earlier kernel versions and if so, how
far back in time does it go?
Thanks.
next prev parent reply other threads:[~2013-08-14 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 13:50 [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error Vyacheslav Dubeyko
2013-08-13 16:51 ` Ryusuke Konishi
2013-08-14 23:00 ` Andrew Morton [this message]
2013-08-14 23:41 ` Ryusuke Konishi
[not found] ` <20130815.084112.220043622.konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2013-08-14 23:45 ` Andrew Morton
2013-08-15 0:25 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814160001.3fa9e4dabb7dca81dab31e87@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox