Linux NILFS development
 help / color / mirror / Atom feed
From: Karel Zak <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Ryusuke Konishi
	<konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Cc: Heinz Diehl <htd+ml-iEI8Y0CNJBYdnm+yROfE0A@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: NILFS2: double uuid
Date: Tue, 9 Jun 2015 16:07:42 +0200	[thread overview]
Message-ID: <20150609140742.GH1992@ws.net.home> (raw)
In-Reply-To: <5576E44F.5030201-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>

On Tue, Jun 09, 2015 at 10:04:15PM +0900, Ryusuke Konishi wrote:
> $ sudo nilfs-resize -y /dev/sdb1 1G
> Partition size = 2146435072 bytes.
> Shrink the filesystem size from 2146435072 bytes to 1073741824 bytes.
> 128 segments will be truncated from segnum 127.
> Moving 103 in-use segments.
> progress |***********************************************|
> Done.
> 
> $ sudo umount /test
> $ sudo mount /dev/sdb1 /test
> $ sudo LD_LIBRARY_PATH=/usr/local/lib lsblk -f
> NAME   FSTYPE  LABEL           UUID MOUNTPOINT
> [...]
> sdb
> `-sdb1                                                              /test
> 
> This blank state continued until I shrank the partition or
> re-extended the filesystem to the partition size.
> 
> Could you consider confining the s_dev_size test only to the
> backup superblock ?

Hmm... why nilfs-resize does not update the size in the superblock?
It seems like nilfs-resize bug.

> It seems that we don't have to drop the primary super block
> even if s_dev_size doesn't fit to the partition size.

Yes, fixed. I have also enabled the s_dev_size check for whole-disk
devices only to minimize number of situations when we rely on the
s_dev_size.

    Karel

-- 
 Karel Zak  <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-06-09 14:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150608064314.GA3172@fritha.org>
2015-06-08  8:18 ` NILFS2: double uuid Ryusuke Konishi
     [not found]   ` <55754FDA.10406-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2015-06-08  9:45     ` Heinz Diehl
     [not found]       ` <20150608094559.GB15702-iEI8Y0CNJBYdnm+yROfE0A@public.gmane.org>
2015-06-08 10:08         ` Heinz Diehl
     [not found]           ` <20150608100835.GA16569-iEI8Y0CNJBYdnm+yROfE0A@public.gmane.org>
2015-06-08 10:12             ` Heinz Diehl
2015-06-08 10:31             ` Ryusuke Konishi
     [not found]               ` <55756F17.7080603-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2015-06-08 15:31                 ` Ryusuke Konishi
     [not found]                   ` <20150609.003127.1516615115859573912.konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2015-06-08 17:23                     ` Heinz Diehl
     [not found]                       ` <20150608172324.GA7760-iEI8Y0CNJBYdnm+yROfE0A@public.gmane.org>
2015-06-09  5:45                         ` Heinz Diehl
2015-06-09  8:53                     ` Karel Zak
2015-06-09  9:46                       ` Heinz Diehl
     [not found]                       ` <20150609085329.GF1992-xkT7n84Rsxv/9pzu0YdTqQ@public.gmane.org>
2015-06-09 13:04                         ` Ryusuke Konishi
     [not found]                           ` <5576E44F.5030201-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2015-06-09 14:07                             ` Karel Zak [this message]
     [not found]                               ` <20150609140742.GH1992-xkT7n84Rsxv/9pzu0YdTqQ@public.gmane.org>
2015-06-09 16:00                                 ` Ryusuke Konishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609140742.GH1992@ws.net.home \
    --to=kzak-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=htd+ml-iEI8Y0CNJBYdnm+yROfE0A@public.gmane.org \
    --cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox