From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: [PATCH 3/3] mm: set mapping error when launder_pages fails Date: Sun, 5 Mar 2017 08:35:35 -0500 Message-ID: <20170305133535.6516-4-jlayton@redhat.com> References: <20170305133535.6516-1-jlayton@redhat.com> Return-path: In-Reply-To: <20170305133535.6516-1-jlayton@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: viro@zeniv.linux.org.uk, konishi.ryusuke@lab.ntt.co.jp Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org If launder_page fails, then we hit a problem writing back some inode data. Ensure that we communicate that fact in a subsequent fsync since another task could still have it open for write. Signed-off-by: Jeff Layton --- mm/truncate.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/truncate.c b/mm/truncate.c index dd7b24e083c5..49ad4e2a6cb6 100644 --- a/mm/truncate.c +++ b/mm/truncate.c @@ -593,11 +593,15 @@ invalidate_complete_page2(struct address_space *mapping, struct page *page) static int do_launder_page(struct address_space *mapping, struct page *page) { + int ret; + if (!PageDirty(page)) return 0; if (page->mapping != mapping || mapping->a_ops->launder_page == NULL) return 0; - return mapping->a_ops->launder_page(page); + ret = mapping->a_ops->launder_page(page); + mapping_set_error(mapping, ret); + return ret; } /** -- 2.9.3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org