From: Steven Rostedt <rostedt@goodmis.org>
To: Waiman Long <longman@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, linux-nilfs@vger.kernel.org,
cluster-devel@redhat.com,
Bart Van Assche <Bart.VanAssche@wdc.com>
Subject: Re: [PATCH v6 0/2] blktrace: Fix deadlock problem
Date: Mon, 18 Sep 2017 17:14:47 -0400 [thread overview]
Message-ID: <20170918171447.697d8659@gandalf.local.home> (raw)
In-Reply-To: <1505760831-7747-1-git-send-email-longman@redhat.com>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
for the series.
Jens, feel free to take this in your tree.
-- Steve
On Mon, 18 Sep 2017 14:53:49 -0400
Waiman Long <longman@redhat.com> wrote:
> v6:
> - Add a second patch to rename the bd_fsfreeze_mutex to
> bd_fsfreeze_blktrace_mutex.
>
> v5:
> - Overload the bd_fsfreeze_mutex in block_device structure for
> blktrace protection.
>
> v4:
> - Use blktrace_mutex in blk_trace_ioctl() as well.
>
> v3:
> - Use a global blktrace_mutex to serialize sysfs attribute accesses
> instead of the bd_mutex.
>
> v2:
> - Use READ_ONCE() and smp_store_mb() to read and write bd_deleting.
> - Check for signal in the mutex_trylock loops.
> - Use usleep() instead of schedule() for RT tasks.
>
> This patchset fixes a potential blktrace deadlock problem between
> block device deletion and sysfs operations.
>
> Waiman Long (2):
> blktrace: Fix potentail deadlock between delete & sysfs ops
> block_dev: Rename bd_fsfreeze_mutex
>
> fs/block_dev.c | 14 +++++++-------
> fs/gfs2/ops_fstype.c | 6 +++---
> fs/nilfs2/super.c | 6 +++---
> fs/super.c | 6 +++---
> include/linux/fs.h | 5 +++--
> kernel/trace/blktrace.c | 26 ++++++++++++++++++++------
> 6 files changed, 39 insertions(+), 24 deletions(-)
>
prev parent reply other threads:[~2017-09-18 21:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 18:53 [PATCH v6 0/2] blktrace: Fix deadlock problem Waiman Long
2017-09-18 18:53 ` [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete & sysfs ops Waiman Long
[not found] ` <1505760831-7747-2-git-send-email-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-09-19 0:01 ` Christoph Hellwig
2017-09-19 12:49 ` Waiman Long
2017-09-19 14:38 ` Christoph Hellwig
2017-09-19 15:58 ` Waiman Long
2017-09-19 20:41 ` Christoph Hellwig
2017-09-19 21:58 ` Steven Rostedt
2017-09-18 18:53 ` [PATCH v6 2/2] block_dev: Rename bd_fsfreeze_mutex Waiman Long
[not found] ` <1505760831-7747-3-git-send-email-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-09-18 23:47 ` Christoph Hellwig
2017-09-19 12:43 ` Waiman Long
2017-09-18 21:14 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918171447.697d8659@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=cluster-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).