From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] radix tree test suite: fix mapshift build target Date: Thu, 12 Apr 2018 14:15:43 -0700 Message-ID: <20180412141543.a9d587c3836338e78de33d30@linux-foundation.org> References: <20180412210518.27557-1-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180412210518.27557-1-ross.zwisler@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Ross Zwisler Cc: Matthew Wilcox , LKML , Linux MM , linux-fsdevel , Ryusuke Konishi , linux-nilfs@vger.kernel.org On Thu, 12 Apr 2018 15:05:18 -0600 Ross Zwisler wrote: > The following commit > > commit c6ce3e2fe3da ("radix tree test suite: Add config option for map > shift") > > Introduced a phony makefile target called 'mapshift' that ends up > generating the file generated/map-shift.h. This phony target was then > added as a dependency of the top level 'targets' build target, which is > what is run when you go to tools/testing/radix-tree and just type 'make'. > > Unfortunately, this phony target doesn't actually work as a dependency, so > you end up getting: > > $ make > make: *** No rule to make target 'generated/map-shift.h', needed by 'main.o'. Stop. > make: *** Waiting for unfinished jobs.... > > Fix this by making the file generated/map-shift.h our real makefile target, > and add this a dependency of the top level build target. I still get akpm3:/usr/src/25/tools/testing/radix-tree> make cc -I. -I../../include -g -O2 -Wall -D_LGPL_SOURCE -fsanitize=address -c -o main.o main.c In file included from ./linux/../../../../include/linux/radix-tree.h:28:0, from ./linux/radix-tree.h:6, from main.c:10: ./linux/rcupdate.h:5:10: fatal error: urcu.h: No such file or directory #include lots of breakage here :(