From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH v11 00/63] Convert page cache to XArray Date: Thu, 31 May 2018 15:36:43 -0600 Message-ID: <20180531213643.GD28256@linux.intel.com> References: <20180414141316.7167-1-willy@infradead.org> <20180416160133.GA12434@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nnR/Bj95p+h5OhGv63wNcZiK0iwE7VeJRaFDlXwbLOo=; b=iXROwgdIqF9/woaQa9ZmIdn66i u3KSMFp0zBG3vqW+cxC+Q1DeSDy8YTRrhSmVCbP1q42FZzOjL3B8ZKXId+IRXKU9vE7afGDY84lnN GArkx0E4xrqaAtgy8HApCWKBOB6P7CQOovNtedwhZ/A0PKiopKGCuMqDzZ78Z4aKPV2Y=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:To: From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nnR/Bj95p+h5OhGv63wNcZiK0iwE7VeJRaFDlXwbLOo=; b=C7OJslGIdt4AaC2EQfvekLTysN wMlk4+wje2Lv0qzLZOccgQ8MVK7hBYZnlhw7I3q2bWMsZ7utgQafnmeKJ7zd80USgEyWWdNlQ2V97 tfIHew7jpQWG3Mxg4AxpxrWk5aLkzX6eoJVnpys/hXqY4UMvskTkzaaNZfNhByoELaMg=; Content-Disposition: inline In-Reply-To: <20180416160133.GA12434@linux.intel.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Ross Zwisler , Matthew Wilcox , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , Jan Kara , Jeff Layton , Lukas Czerner , Christoph Hellwig , Goldwyn Rodrigues , Nicholas Piggin , Ryusuke Konishi , linux-nilfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Oleg Drokin , Andreas Dilger , James Simmons , Mike Kravetz On Mon, Apr 16, 2018 at 10:01:33AM -0600, Ross Zwisler wrote: > On Sat, Apr 14, 2018 at 07:12:13AM -0700, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > This conversion keeps the radix tree and XArray data structures in sync > > at all times. That allows us to convert the page cache one function at > > a time and should allow for easier bisection. Other than renaming some > > elements of the structures, the data structures are fundamentally > > unchanged; a radix tree walk and an XArray walk will touch the same > > number of cachelines. I have changes planned to the XArray data > > structure, but those will happen in future patches. > > I've hit a few failures when throwing this into my test setup. The first two > seem like similar bugs hit in two different ways, the third seems unique. > I've verified that these don't seem to happen with the next-20180413 baseline. Hey Matthew, did you ever figure out these failures? ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot