From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Darrick J. Wong" Subject: Re: [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS Date: Tue, 11 Jun 2019 17:35:38 -0700 Message-ID: <20190612003538.GW1871505@magnolia> References: <156022833285.3227089.11990489625041926920.stgit@magnolia> <156022834076.3227089.14763553158562888103.stgit@magnolia> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9gKawnpnm3eYTlbJSmpS31BgWCZu6yO6zvRDwLNExMc=; b=jPwxmPjvRJZI/Ug89NjIItK41r WfnSor/J9xquS06gd+Q4HGb3GsXhPR403ZpkQZrZpXmRQlmXC38f/r1w+JI3mJf5bei7DIPgqFNpI rornkXEMMlYJnov6XKgT0b1mf4s9Uad9zbJsg4WrUPCJiVFrkABFIlPAVm+fBn/WPoOE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9gKawnpnm3eYTlbJSmpS31BgWCZu6yO6zvRDwLNExMc=; b=JqGMEUA6oxN7He30H9OQYqzjwZ 8yido6ZVkOX6CMKB9Vkubk6s1xGhDTX8Ous9yWaYHC0yTTpUC8SqJ1R8frrI/MV5DyyGgnAvSH/xa QAZnrlStb4pM0atOicLgCQazGUc5tiQY3kJgy5YKFNP5IjOV/OjarRifk9i1DKnK7UCE=; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=9gKawnpnm3eYTlbJSmpS31BgWCZu6yO6zvRDwLNExMc=; b=vHQc7RiwFlRopnBcV6yXscL30ZNdwN/v/B17eINRtpQHvUvgM6epdVedyPbAKdmcBBV3 cpQKUJvANpmF9rest4EECBPlFj+c/6FFyA1MB+Y7QHfaviX1SgktsC/OuLuEeHTjfJfn IHVrIivC0Er8GlXskbXJ6t5OZcUHTAMhyEJ0O8MOVdKDEgKTHfWtz59o9kiNq/kqTY6E 4hAomBRtHJLX3EPEAvdgUe3wJJHguniVZBFYytUSwIeEiPqdsoMO2S6x/RCI4kCCEC8X 5tzrNpCpeUTAjMu2i0Q0axAMVtIdwT/+kMGJyGR6ACAIOztQv/pzRx3K8FTZ+teYFImj 5Q== Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: jfs-discussion-bounces@lists.sourceforge.net To: Dave Kleikamp Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net, linux-efi@vger.kernel.org, yuchao0@huawei.com, clm@fb.com, adilger.kernel@dilger.ca, ocfs2-devel@oss.oracle.com, matthew.garrett@nebula.com, linux-nilfs@vger.kernel.org, cluster-devel@redhat.com, linux-ext4@vger.kernel.org, reiserfs-devel@vger.kernel.org, josef@toxicpanda.com, viro@zeniv.linux.org.uk, dsterba@suse.com, jaegeuk@kernel.org, tytso@mit.edu, ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, jk@ozlabs.org, jack@suse.com, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org On Tue, Jun 11, 2019 at 08:41:06AM -0500, Dave Kleikamp wrote: > On 6/10/19 11:45 PM, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag > > values so that we can standardize the implementations that follow ext4's > > flag values. > > > > Signed-off-by: Darrick J. Wong > > -- clip -- > > > diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c > > index ba34dae8bd9f..c8446d2cd0c7 100644 > > --- a/fs/jfs/ioctl.c > > +++ b/fs/jfs/ioctl.c > > @@ -98,6 +98,12 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > > /* Lock against other parallel changes of flags */ > > inode_lock(inode); > > > > + oldflags = jfs_map_ext2(jfs_inode->mode2 & JFS_FL_USER_VISIBLE, > > + 0); > > + err = vfs_ioc_setflags_check(inode, oldflags, flags); > > + if (err) > > + goto setflags_out; > > inode_unlock(inode) is not called on the error path. > > > + > > oldflags = jfs_inode->mode2; > > > > /* > > This patch leaves jfs's open-coded version of the same check. Heh, thanks for pointing that out. I'll fix both of those things. --D > Thanks, > Shaggy