From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Darrick J. Wong" Subject: Re: [RFC PATCH 27/34] xfs: use bio_new in xfs_buf_ioapply_map Date: Thu, 28 Jan 2021 09:21:51 -0800 Message-ID: <20210128172151.GN7698@magnolia> References: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> <20210128071133.60335-28-chaitanya.kulkarni@wdc.com> Mime-Version: 1.0 Return-path: List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611854512; bh=3wcbDXIsfKokQbmfUCYjGrgS3GF5z08Qdptdga5fUN4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QWOP7EPqmN6b3MiW9yEAgNNtNjSRtrXyFEpjaAGYBZII1sVNYI1YtSMwAvt9fuQBa 67CiLo3o5RvfcoATyHS1j02NITEEA3iqExwlLXezGs5RMp4QWJbqX9Dn+nc6m+I4rS ryQ81C45k5DR4mIk6Zm2DTepJlJx7ughkR/Vt0AUwH3+rYDSQLjDOWM7DJGp0ETUnl xurghfp/gRCwfqedNMDMPHZbg7F0alqw1H/gKUa0SjDmFnvopggMP4TjgUC2t6LP2S 1ujXulQBT2zqjOQLupxjXSsgT0HMqyI+WyoITl6y/0OvHf8iHp4HzyLmR4yVI/FSxp yznAeENjD3n6w== Content-Disposition: inline In-Reply-To: <20210128071133.60335-28-chaitanya.kulkarni@wdc.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chaitanya Kulkarni Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, xen-devel@lists.xenproject.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fscrypt@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, axboe@kernel.dk, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, konrad.wilk@oracle.com, roger.pau@citrix.com, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, agk@redhat.com, snitzer@redhat.com, hch@lst.de, sagi@grimberg.me, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, tytso@mit.edu, jaegeuk@kernel.org, ebiggers@kernel.org, shaggy@kernel.org, konishi.ryusuke@gmail.com, mark@fashe On Wed, Jan 27, 2021 at 11:11:26PM -0800, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_buf.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index f8400bbd6473..3ff6235e4f94 100644 > --- a/fs/xfs/xfs_buf.c > +++ b/fs/xfs/xfs_buf.c > @@ -1507,12 +1507,10 @@ xfs_buf_ioapply_map( > atomic_inc(&bp->b_io_remaining); > nr_pages = min(total_nr_pages, BIO_MAX_PAGES); > > - bio = bio_alloc(GFP_NOIO, nr_pages); > - bio_set_dev(bio, bp->b_target->bt_bdev); > - bio->bi_iter.bi_sector = sector; > + bio = bio_new(bp->b_target->bt_bdev, sector, op, 0, nr_pages, > + GFP_NOIO); > bio->bi_end_io = xfs_buf_bio_end_io; > bio->bi_private = bp; > - bio->bi_opf = op; > > for (; size && nr_pages; nr_pages--, page_index++) { > int rbytes, nbytes = PAGE_SIZE - offset; > -- > 2.22.1 >