From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH AUTOSEL 5.4 12/12] nilfs2: fix memory leak in nilfs_sysfs_delete_snapshot_group Date: Mon, 13 Sep 2021 18:35:04 -0400 Message-ID: <20210913223504.436087-12-sashal@kernel.org> References: <20210913223504.436087-1-sashal@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631572521; bh=eQ3LCeWRN8D9/OAav1FmOG19LmXMe7aLh9WavSLwbbc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Deq+iG95cL0ks/F+1LHVLtWxNxEfj9Iixw6FZBSm/wJBhq758+oUegB/TEgJRAwZG i9Ut5MJZDbmGwTltvC4Ky2SIPJf2Z0qk2MA4yk5mJ6tVpVN4/29o+JWonsNRfTcCuM t2Kc7i4u7ndOZmti/w5ChYxCtpuR8iu+dwz5NbZTyxQqJ/cWt8GdRhu2aG90Lk4eFl AxbyvM+WtMbUfq9ja9CQYRLOPdTGLt9UGK91c7IKss+B78kgkL9TFshdgK+CA+CNJF 8qrHqgxCTK1jyvjY5b95p8TbndUc2Gm7Hqb2wyiY6F3rsZHUnv+5shw3X4NvpSowyI HYm2T0TisSmxw== In-Reply-To: <20210913223504.436087-1-sashal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Nanyong Sun , Ryusuke Konishi , Andrew Morton , Linus Torvalds , Sasha Levin , linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org From: Nanyong Sun [ Upstream commit 17243e1c3072b8417a5ebfc53065d0a87af7ca77 ] kobject_put() should be used to cleanup the memory associated with the kobject instead of kobject_del(). See the section "Kobject removal" of "Documentation/core-api/kobject.rst". Link: https://lkml.kernel.org/r/20210629022556.3985106-7-sunnanyong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Link: https://lkml.kernel.org/r/1625651306-10829-7-git-send-email-konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Signed-off-by: Nanyong Sun Signed-off-by: Ryusuke Konishi Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/nilfs2/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c index 6c92ac314b06..28a2db3b1787 100644 --- a/fs/nilfs2/sysfs.c +++ b/fs/nilfs2/sysfs.c @@ -215,7 +215,7 @@ int nilfs_sysfs_create_snapshot_group(struct nilfs_root *root) void nilfs_sysfs_delete_snapshot_group(struct nilfs_root *root) { - kobject_del(&root->snapshot_kobj); + kobject_put(&root->snapshot_kobj); } /************************************************************************ -- 2.30.2