From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH AUTOSEL 4.19 09/10] nilfs2: fix memory leak in nilfs_sysfs_create_snapshot_group Date: Mon, 13 Sep 2021 18:35:20 -0400 Message-ID: <20210913223521.436250-9-sashal@kernel.org> References: <20210913223521.436250-1-sashal@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631572533; bh=EzL9KJn4SWgGVEjHbrIl82g6//S9PtBM8R84vzpgyao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Br+XiIkG9F8aFYK7W7xWlIUtdlxpFvcUp/wwHoFhN8tCRvMSlo4rqNhpTDCB9LWf2 KO6Gs0WDjZ1630aMlAV81F63SkKloI05YtPaQVfLv5pEWGfZ5LaeJzUOcVLq4NQC1u pc5OvvTjPS1/JKmz1rCiKJzAEB3QZUirJWGzpHkPisusEOo0m+Qy3qdVgztHWG0Bi3 b7pDTvE6X3FxzeDDY6370dypLC72pnWuBlitt0Wx3Ex0xDPIuWXsBFcE/QktOzTC9X P95PFIIg9NA1gI/+EO7nzCeTuz5tQdHyNR/vhmV1smH5U8qxKFxCWLtaCsyAb6lDxI JkLpfOBYWFcXw== In-Reply-To: <20210913223521.436250-1-sashal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Nanyong Sun , Ryusuke Konishi , Andrew Morton , Linus Torvalds , Sasha Levin , linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org From: Nanyong Sun [ Upstream commit b2fe39c248f3fa4bbb2a20759b4fdd83504190f7 ] If kobject_init_and_add returns with error, kobject_put() is needed here to avoid memory leak, because kobject_init_and_add may return error without freeing the memory associated with the kobject it allocated. Link: https://lkml.kernel.org/r/20210629022556.3985106-6-sunnanyong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Link: https://lkml.kernel.org/r/1625651306-10829-6-git-send-email-konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Signed-off-by: Nanyong Sun Signed-off-by: Ryusuke Konishi Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/nilfs2/sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c index 195f42192a15..6c92ac314b06 100644 --- a/fs/nilfs2/sysfs.c +++ b/fs/nilfs2/sysfs.c @@ -208,9 +208,9 @@ int nilfs_sysfs_create_snapshot_group(struct nilfs_root *root) } if (err) - return err; + kobject_put(&root->snapshot_kobj); - return 0; + return err; } void nilfs_sysfs_delete_snapshot_group(struct nilfs_root *root) -- 2.30.2