From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 01/31] block: also call ->open for incremental partition opens Date: Wed, 7 Jun 2023 10:32:53 +0200 Message-ID: <20230607083253.GA29653@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-2-hch@lst.de> <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christian Brauner Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , "Rafael J. Wysocki" , Pavel Machek , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-nvme@lists. On Wed, Jun 07, 2023 at 10:14:22AM +0200, Christian Brauner wrote: > This assumes that all drivers deal with additional ->open() calls for > each partition correctly which I assumed you checked so, They have to, because they already get the additional open for extra opens of the whole device. The current behavior is: open("/dev/vdb", ...) ->open called open("/dev/vdb", ...) ->open called ---- open("/dev/vdb", ...) ->open called open("/dev/vdb1", ...) ->open called ---- open("/dev/vdb1", ...) ->open called open("/dev/vdb1", ...) ->open NOT called which is very inconsistent.