From: Christoph Hellwig <hch@lst.de>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: ebiggers@google.com, Christian Brauner <brauner@kernel.org>,
hch@lst.de, linux-nilfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Ryusuke Konishi <konishi.ryusuke@gmail.com>
Subject: Re: [PATCH -next] nilfs2: support STATX_DIOALIGN for statx file
Date: Wed, 28 Aug 2024 07:11:10 +0200 [thread overview]
Message-ID: <20240828051110.GA31869@lst.de> (raw)
In-Reply-To: <86e1541f-0d8b-4479-b8d1-bb5a9f5849d4@huawei.com>
On Wed, Aug 28, 2024 at 09:12:50AM +0800, Hongbo Li wrote:
>> I checked the STATX_DIOALIGN specification while looking at the
>> implementation of other file systems, and I thought that if DIO
>> support is incomplete, the dio_xx_align member should be set to 0.
>>
>> Due to the nature of NILFS2 as a log-structured file system, DIO
>> writes fall back to buffered io. (DIO reads are supported)
>>
> That's really a question. How to handle the asymmetric situation of
> O_DIRECT read and write?
>
> The STATX_DIOALIGN specification does not define this case.
Yes, it needs separate reporting for the read alignment. I actually
wrote patches for that a few days ago, but never got around to testing
them. I'll send out what I have.
next prev parent reply other threads:[~2024-08-28 5:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 1:51 [PATCH -next] nilfs2: support STATX_DIOALIGN for statx file Hongbo Li
2024-08-27 18:15 ` Ryusuke Konishi
2024-08-28 1:12 ` Hongbo Li
2024-08-28 5:11 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-08-27 2:00 Hongbo Li
2024-08-27 1:55 ` Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828051110.GA31869@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=ebiggers@google.com \
--cc=konishi.ryusuke@gmail.com \
--cc=lihongbo22@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).