* [PATCH] nilfs2: Remove duplicate 'unlikely()' usage
@ 2024-08-29 7:16 Kunwu Chan
2024-08-29 16:47 ` Ryusuke Konishi
0 siblings, 1 reply; 3+ messages in thread
From: Kunwu Chan @ 2024-08-29 7:16 UTC (permalink / raw)
To: konishi.ryusuke; +Cc: linux-nilfs, linux-kernel, Kunwu Chan
From: Kunwu Chan <chentao@kylinos.cn>
nested unlikely() calls, IS_ERR already uses unlikely() internally
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---
fs/nilfs2/page.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c
index 7797903e014e..9c0b7cddeaae 100644
--- a/fs/nilfs2/page.c
+++ b/fs/nilfs2/page.c
@@ -262,7 +262,7 @@ int nilfs_copy_dirty_pages(struct address_space *dmap,
NILFS_FOLIO_BUG(folio, "inconsistent dirty state");
dfolio = filemap_grab_folio(dmap, folio->index);
- if (unlikely(IS_ERR(dfolio))) {
+ if (IS_ERR(dfolio)) {
/* No empty page is added to the page cache */
folio_unlock(folio);
err = PTR_ERR(dfolio);
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nilfs2: Remove duplicate 'unlikely()' usage
2024-08-29 7:16 [PATCH] nilfs2: Remove duplicate 'unlikely()' usage Kunwu Chan
@ 2024-08-29 16:47 ` Ryusuke Konishi
0 siblings, 0 replies; 3+ messages in thread
From: Ryusuke Konishi @ 2024-08-29 16:47 UTC (permalink / raw)
To: Kunwu Chan; +Cc: linux-nilfs, linux-kernel, Kunwu Chan
On Thu, Aug 29, 2024 at 4:16 PM Kunwu Chan wrote:
>
> From: Kunwu Chan <chentao@kylinos.cn>
>
> nested unlikely() calls, IS_ERR already uses unlikely() internally
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> ---
> fs/nilfs2/page.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c
> index 7797903e014e..9c0b7cddeaae 100644
> --- a/fs/nilfs2/page.c
> +++ b/fs/nilfs2/page.c
> @@ -262,7 +262,7 @@ int nilfs_copy_dirty_pages(struct address_space *dmap,
> NILFS_FOLIO_BUG(folio, "inconsistent dirty state");
>
> dfolio = filemap_grab_folio(dmap, folio->index);
> - if (unlikely(IS_ERR(dfolio))) {
> + if (IS_ERR(dfolio)) {
> /* No empty page is added to the page cache */
> folio_unlock(folio);
> err = PTR_ERR(dfolio);
> --
> 2.41.0
>
Thank you. I'll pick it up.
Ryusuke Konishi
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nilfs2: Remove duplicate 'unlikely()' usage
@ 2024-09-04 10:16 Ryusuke Konishi
0 siblings, 0 replies; 3+ messages in thread
From: Ryusuke Konishi @ 2024-09-04 10:16 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-nilfs, LKML
From: Kunwu Chan <chentao@kylinos.cn>
nested unlikely() calls, IS_ERR already uses unlikely() internally
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
---
Andrew, please add this to the queue for the next cycle.
An additional cleanup patch.
Thanks,
Ryusuke Konishi
fs/nilfs2/page.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c
index 7797903e014e..9c0b7cddeaae 100644
--- a/fs/nilfs2/page.c
+++ b/fs/nilfs2/page.c
@@ -262,7 +262,7 @@ int nilfs_copy_dirty_pages(struct address_space *dmap,
NILFS_FOLIO_BUG(folio, "inconsistent dirty state");
dfolio = filemap_grab_folio(dmap, folio->index);
- if (unlikely(IS_ERR(dfolio))) {
+ if (IS_ERR(dfolio)) {
/* No empty page is added to the page cache */
folio_unlock(folio);
err = PTR_ERR(dfolio);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-04 10:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 7:16 [PATCH] nilfs2: Remove duplicate 'unlikely()' usage Kunwu Chan
2024-08-29 16:47 ` Ryusuke Konishi
-- strict thread matches above, loose matches on Subject: below --
2024-09-04 10:16 Ryusuke Konishi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).