From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Hongbo Li <lihongbo22@huawei.com>,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/4] fs: add STATX_DIO_READ_ALIGN
Date: Mon, 6 Jan 2025 17:40:08 +0100 [thread overview]
Message-ID: <20250106164008.GA29273@lst.de> (raw)
In-Reply-To: <o2gecwhofinap2qolyomkaijaeaorbqnqw4othvpwl4eqhdieo@a57gqldklqi7>
On Mon, Jan 06, 2025 at 05:32:14PM +0100, Jan Kara wrote:
> > Add a separate dio read align field, as many out of place write
> > file systems can easily do reads aligned to the device sector size,
> > but require bigger alignment for writes.
> >
> > This is usually papered over by falling back to buffered I/O for smaller
> > writes and doing read-modify-write cycles, but performance for this
> > sucks, so applications benefit from knowing the actual write alignment.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> So if I understand right dio_offset_align is guaranteed to work for all DIO
> (i.e., maximum of all possible alignments), dio_read_offset_align is
> possibly lower and works only for reads.
Yes. If you think this needs to be made more clear I'm open to
suggestions to improve the wording.
next prev parent reply other threads:[~2025-01-06 16:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 15:15 add STATX_DIO_READ_ALIGN Christoph Hellwig
2025-01-06 15:15 ` [PATCH 1/4] fs: reformat the statx definition Christoph Hellwig
2025-01-06 16:28 ` Jan Kara
2025-01-06 15:15 ` [PATCH 2/4] fs: add STATX_DIO_READ_ALIGN Christoph Hellwig
2025-01-06 16:32 ` Jan Kara
2025-01-06 16:40 ` Christoph Hellwig [this message]
2025-01-06 15:15 ` [PATCH 3/4] xfs: cleanup xfs_vn_getattr Christoph Hellwig
2025-01-06 17:07 ` John Garry
2025-01-06 15:15 ` [PATCH 4/4] xfs: report the correct read/write dio alignment for reflinked inodes Christoph Hellwig
2025-01-06 17:33 ` Darrick J. Wong
2025-01-06 18:37 ` John Garry
2025-01-07 6:10 ` Christoph Hellwig
2025-01-07 7:03 ` Darrick J. Wong
2025-01-07 9:00 ` John Garry
2025-01-06 15:19 ` [PATCH] statx.2: document STATX_DIO_READ_ALIGN Christoph Hellwig
2025-01-06 17:40 ` Darrick J. Wong
2025-01-06 18:09 ` Christoph Hellwig
2025-01-06 19:09 ` Darrick J. Wong
2025-01-06 22:01 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106164008.GA29273@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=konishi.ryusuke@gmail.com \
--cc=lihongbo22@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).