Linux NILFS development
 help / color / mirror / Atom feed
From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Brian G ." <gissf1@gmail.com>,
	linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH -v2 0/7] nilfs2: fix kernel-doc comments for function return values
Date: Fri, 10 Jan 2025 10:01:43 +0900	[thread overview]
Message-ID: <20250110010530.21872-1-konishi.ryusuke@gmail.com> (raw)
In-Reply-To: <CAKFNMoksY6f5NtVwmn6K0K2QKTvdjq+s0FbdgLvHzS3YueKqYQ@mail.gmail.com>

This series fixes the inadequacies in the return value descriptions in
nilfs2's kernel-doc comments (mainly incorrect formatting), as well as
the lack of return value descriptions themselves, and fixes most of
the remaining warnings that are output when the kernel-doc script is
run with the "-Wall" option.

Changes since v1 (in response to Brian G.'s comments):
- Fix typos in the comments.  Plus, fix spell checker detections.
- Fix missing -ENOMEM in the return code list of nilfs_ioctl_set_suinfo().
- Ensure that the adjective "negative" is included for negative error
 codes.
- Change the description style of return codes that list multiple error
 codes to match "..., or one of the following negative error codes on
 failure:" (applied across patches).
- Apply similar style adjustments to existing return code descriptions that
 are not warned about by the kernel-doc script (patch 7/7).

The patch 7/7 is an addition, and the rest are revisions that correspond
one-to-one to the -v1 series.

Thanks,
Ryusuke Konishi

Ryusuke Konishi (7):
  nilfs2: correct return value kernel-doc descriptions for ioctl
    functions
  nilfs2: correct return value kernel-doc descriptions for bmap
    functions
  nilfs2: correct return value kernel-doc descriptions for sufile
  nilfs2: correct return value kernel-doc descriptions for metadata
    files
  nilfs2: correct return value kernel-doc descriptions for the rest
  nilfs2: add missing return value kernel-doc descriptions
  nilfs2: revise the return value description style for consistency.

 fs/nilfs2/alloc.c     |  67 +++++++++++-
 fs/nilfs2/alloc.h     |   2 +
 fs/nilfs2/bmap.c      | 124 ++++++++++------------
 fs/nilfs2/btnode.c    |   3 +-
 fs/nilfs2/btree.c     |   7 +-
 fs/nilfs2/cpfile.c    |  69 ++++++------
 fs/nilfs2/dat.c       |  45 ++++----
 fs/nilfs2/gcinode.c   |  24 ++---
 fs/nilfs2/ifile.c     |  37 ++++---
 fs/nilfs2/inode.c     |  16 ++-
 fs/nilfs2/ioctl.c     | 236 ++++++++++++++++++------------------------
 fs/nilfs2/mdt.c       |  63 ++++++-----
 fs/nilfs2/page.c      |   8 +-
 fs/nilfs2/recovery.c  |  62 +++++++----
 fs/nilfs2/segbuf.c    |  12 +--
 fs/nilfs2/segment.c   |  62 ++++++-----
 fs/nilfs2/sufile.c    | 112 +++++++++-----------
 fs/nilfs2/sufile.h    |  22 ++--
 fs/nilfs2/super.c     |  10 +-
 fs/nilfs2/the_nilfs.c |  26 +++--
 20 files changed, 507 insertions(+), 500 deletions(-)

-- 
2.43.0


  reply	other threads:[~2025-01-10  1:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09  3:23 [PATCH 0/6] nilfs2: fix kernel-doc comments for function return values Ryusuke Konishi
2025-01-09  3:23 ` [PATCH 1/6] nilfs2: correct return value kernel-doc descriptions for ioctl functions Ryusuke Konishi
2025-01-09 13:44   ` Brian G.
2025-01-09 14:38     ` Ryusuke Konishi
2025-01-10  1:01       ` Ryusuke Konishi [this message]
2025-01-10  1:01         ` [PATCH -v2 1/7] " Ryusuke Konishi
2025-01-10  1:01         ` [PATCH -v2 2/7] nilfs2: correct return value kernel-doc descriptions for bmap functions Ryusuke Konishi
2025-01-10  1:01         ` [PATCH -v2 3/7] nilfs2: correct return value kernel-doc descriptions for sufile Ryusuke Konishi
2025-01-10  1:01         ` [PATCH -v2 4/7] nilfs2: correct return value kernel-doc descriptions for metadata files Ryusuke Konishi
2025-01-10  1:01         ` [PATCH -v2 5/7] nilfs2: correct return value kernel-doc descriptions for the rest Ryusuke Konishi
2025-01-10  1:01         ` [PATCH -v2 6/7] nilfs2: add missing return value kernel-doc descriptions Ryusuke Konishi
2025-01-10  1:01         ` [PATCH -v2 7/7] nilfs2: revise the return value description style for consistency Ryusuke Konishi
2025-01-09  3:23 ` [PATCH 2/6] nilfs2: correct return value kernel-doc descriptions for bmap functions Ryusuke Konishi
2025-01-09  3:23 ` [PATCH 3/6] nilfs2: correct return value kernel-doc descriptions for sufile Ryusuke Konishi
2025-01-09  3:23 ` [PATCH 4/6] nilfs2: correct return value kernel-doc descriptions for metadata files Ryusuke Konishi
2025-01-09  3:23 ` [PATCH 5/6] nilfs2: correct return value kernel-doc descriptions for the rest Ryusuke Konishi
2025-01-09  3:23 ` [PATCH 6/6] nilfs2: add missing return value kernel-doc descriptions Ryusuke Konishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250110010530.21872-1-konishi.ryusuke@gmail.com \
    --to=konishi.ryusuke@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=gissf1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nilfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox