From: Christoph Hellwig <hch@lst.de>
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Yosry Ahmed <yosry.ahmed@linux.dev>,
Nhat Pham <nphamcs@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Chengming Zhou <chengming.zhou@linux.dev>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
linux-nilfs@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 6/7] nilfs2: remove wbc->for_reclaim handling
Date: Fri, 16 May 2025 06:55:54 +0200 [thread overview]
Message-ID: <20250516045554.GA13127@lst.de> (raw)
In-Reply-To: <CAKFNMo=nQ7e99ubGmB_9myjSmHxmUJ+XEoknRGF=fMuzJZMPNg@mail.gmail.com>
On Fri, May 09, 2025 at 01:16:36AM +0900, Ryusuke Konishi wrote:
> > Since commit 013a07052a1a ("nilfs2: convert metadata aops from writepage
> > to writepages"), nilfs_mdt_write_folio can't be called from reclaim
> > context any more. Remove the code keyed of the wbc->for_rename flag,
> > which is now only set for writing out swap or shmem pages inside the
> > swap code, but never passed to file systems.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Yes, the parts removed in this patch look like dead code now.
>
> So far, no issues have been detected with the previous conversion, but
> even if it turns out that something has changed in that conversion and
> needs to be fixed, I have no objection to this cleanup. Feel free to
> add:
Can you queue this up in the nilfs2 tree as it's independent of the
previous patches in the series, and the last one can't go in until
all dependencies have been merged anyway?
next prev parent reply other threads:[~2025-05-16 4:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 5:47 stop passing a writeback_control to swap/shmem writeout Christoph Hellwig
2025-05-08 5:47 ` [PATCH 1/7] mm: split out a writeout helper from pageout Christoph Hellwig
2025-05-08 5:47 ` [PATCH 2/7] mm: stop passing a writeback_control structure to shmem_writeout Christoph Hellwig
2025-05-08 13:03 ` kernel test robot
2025-05-08 13:25 ` Matthew Wilcox
2025-05-08 14:03 ` Christoph Hellwig
2025-05-08 5:47 ` [PATCH 3/7] mm: tidy up swap_writeout Christoph Hellwig
2025-05-08 5:47 ` [PATCH 4/7] mm: stop passing a writeback_control structure to __swap_writepage Christoph Hellwig
2025-05-08 5:47 ` [PATCH 5/7] mm: stop passing a writeback_control structure to swap_writeout Christoph Hellwig
2025-05-08 11:38 ` kernel test robot
2025-05-08 5:47 ` [PATCH 6/7] nilfs2: remove wbc->for_reclaim handling Christoph Hellwig
2025-05-08 16:16 ` Ryusuke Konishi
2025-05-16 4:55 ` Christoph Hellwig [this message]
2025-05-16 6:08 ` Ryusuke Konishi
2025-05-08 5:47 ` [PATCH 7/7] mm: remove the for_reclaim field from struct writeback_control Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516045554.GA13127@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-mm@kvack.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=nphamcs@gmail.com \
--cc=willy@infradead.org \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).