From: Jeff Layton <jlayton@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Anders Larsen <al@alarsen.net>,
Carlos Llamas <cmllamas@google.com>,
Andrii Nakryiko <andrii@kernel.org>,
Hugh Dickins <hughd@google.com>,
John Johansen <john.johansen@canonical.com>,
Seth Forshee <sforshee@digitalocean.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christoph Hellwig <hch@lst.de>,
Mike Marshall <hubcap@omnibond.com>,
Paulo Alcantara <pc@manguebit.com>,
linux-xfs@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Michael Ellerman <mpe@ellerman.id.au>,
John Keeping <john@keeping.me.uk>, Zhang Yi <yi.zhang@huawei.com>,
James Morris <jmorris@namei.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Tyler Hicks <code@tyhicks.com>,
Alan Stern <stern@rowland.harvard.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
devel@lists.ora
Subject: Re: [PATCH 00/79] fs: new accessors for inode->i_ctime
Date: Wed, 21 Jun 2023 15:52:27 -0400 [thread overview]
Message-ID: <2a5a069572b46b59dd16fe8d54e549a9b5bbb6eb.camel@kernel.org> (raw)
In-Reply-To: <20230621152141.5961cf5f@gandalf.local.home>
On Wed, 2023-06-21 at 15:21 -0400, Steven Rostedt wrote:
> On Wed, 21 Jun 2023 10:45:05 -0400
> Jeff Layton <jlayton@kernel.org> wrote:
>
> > Most of this conversion was done via coccinelle, with a few of the more
> > non-standard accesses done by hand. There should be no behavioral
> > changes with this set. That will come later, as we convert individual
> > filesystems to use multigrain timestamps.
>
> BTW, Linus has suggested to me that whenever a conccinelle script is used,
> it should be included in the change log.
>
Ok, here's what I have. I note again that my usage of coccinelle is
pretty primitive, so I ended up doing a fair bit of by-hand fixing after
applying these.
Given the way that this change is broken up into 77 patches by
subsystem, to which changelogs should I add it? I could add it to the
"infrastructure" patch, but that's the one where I _didn't_ use it.
Maybe to patch #79 (the one that renames i_ctime)?
------------------------8<------------------------------
@@
expression inode;
@@
- inode->i_ctime = current_time(inode)
+ inode_set_current_ctime(inode)
@@
expression inode;
@@
- inode->i_ctime = inode->i_mtime = current_time(inode)
+ inode->i_mtime = inode_set_current_ctime(inode)
@@
struct inode *inode;
expression value;
@@
- inode->i_ctime = value;
+ inode_set_ctime(inode, value);
@@
struct inode *inode;
expression val;
@@
- inode->i_ctime.tv_sec = val
+ inode_set_ctime_sec(inode, val)
@@
struct inode *inode;
expression val;
@@
- inode->i_ctime.tv_nsec = val
+ inode_set_ctime_nsec(inode, val)
@@
struct inode *inode;
@@
- inode->i_ctime
+ inode_ctime_peek(inode)
next prev parent reply other threads:[~2023-06-21 19:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230621144507.55591-1-jlayton@kernel.org>
[not found] ` <20230621144735.55953-1-jlayton@kernel.org>
[not found] ` <20230621144735.55953-1-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-06-21 14:46 ` [PATCH 47/79] nilfs2: switch to new ctime accessors Jeff Layton
[not found] ` <20230621144735.55953-46-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-06-26 15:26 ` Ryusuke Konishi
2023-06-21 19:21 ` [PATCH 00/79] fs: new accessors for inode->i_ctime Steven Rostedt
2023-06-21 19:52 ` Jeff Layton [this message]
2023-06-23 12:41 ` Christian Brauner
2023-06-30 22:11 ` Luis Chamberlain
[not found] ` <20230621144507.55591-2-jlayton@kernel.org>
2023-06-21 16:34 ` [PATCH 01/79] fs: add ctime accessors infrastructure Jan Kara
[not found] ` <99b3c749-23d9-6f09-fb75-6a84f3d1b066@kernel.org>
[not found] ` <99b3c749-23d9-6f09-fb75-6a84f3d1b066-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-06-22 10:14 ` Jeff Layton
2023-06-30 22:12 ` Luis Chamberlain
[not found] ` <20230621144507.55591-2-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-07-12 15:31 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a5a069572b46b59dd16fe8d54e549a9b5bbb6eb.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=al@alarsen.net \
--cc=andrii@kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=bvanassche@acm.org \
--cc=christophe.leroy@csgroup.eu \
--cc=cmllamas@google.com \
--cc=code@tyhicks.com \
--cc=devel@lists.ora \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=hubcap@omnibond.com \
--cc=hughd@google.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=john@keeping.me.uk \
--cc=linux-xfs@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=mpe@ellerman.id.au \
--cc=pc@manguebit.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sforshee@digitalocean.com \
--cc=stern@rowland.harvard.edu \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).