From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [PATCH 00/79] fs: new accessors for inode->i_ctime Date: Wed, 21 Jun 2023 15:52:27 -0400 Message-ID: <2a5a069572b46b59dd16fe8d54e549a9b5bbb6eb.camel@kernel.org> References: <20230621144507.55591-1-jlayton@kernel.org> <20230621152141.5961cf5f@gandalf.local.home> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687377179; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vTL4Y8a8sFEsX3Xqt4OIZCRU2/7UfNvPDdjp0N/3dJE=; b=LxzT5GoZ2+dfsXMsc3a2bX7LUG0C1S0BEZIjm3BMhmRH+OWz9zlR2MTAUE5PDWcZkt4GG2 ovJWpXlL+jzqZLKPi4XYgYpFsT01eKbbTZ5D9kNbb86M4GPM0kezDk/rHc3qhIxqI9RzmL jGfBgtly1lgehRI7MnBLdzwE+eX1Pig= In-Reply-To: <20230621152141.5961cf5f@gandalf.local.home> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cluster-devel-bounces@redhat.com Sender: "Cluster-devel" Content-Type: text/plain; charset="iso-8859-1" To: Steven Rostedt Cc: Latchesar Ionkov , "Rafael J. Wysocki" , "Darrick J. Wong" , Anders Larsen , Carlos Llamas , Andrii Nakryiko , Hugh Dickins , John Johansen , Seth Forshee , Alexander Gordeev , Christoph Hellwig , Mike Marshall , Paulo Alcantara , linux-xfs@vger.kernel.org, Bart Van Assche , Michael Ellerman , John Keeping , Zhang Yi , James Morris , Christophe Leroy , Tyler Hicks , Alan Stern , Christian Borntraeger , devel@lists.ora On Wed, 2023-06-21 at 15:21 -0400, Steven Rostedt wrote: > On Wed, 21 Jun 2023 10:45:05 -0400 > Jeff Layton wrote: >=20 > > Most of this conversion was done via coccinelle, with a few of the more > > non-standard accesses done by hand. There should be no behavioral > > changes with this set. That will come later, as we convert individual > > filesystems to use multigrain timestamps. >=20 > BTW, Linus has suggested to me that whenever a conccinelle script is used= , > it should be included in the change log. >=20 Ok, here's what I have. I note again that my usage of coccinelle is pretty primitive, so I ended up doing a fair bit of by-hand fixing after applying these. Given the way that this change is broken up into 77 patches by subsystem, to which changelogs should I add it? I could add it to the "infrastructure" patch, but that's the one where I _didn't_ use it.=A0 Maybe to patch #79 (the one that renames i_ctime)? ------------------------8<------------------------------ @@ expression inode; @@ - inode->i_ctime =3D current_time(inode) + inode_set_current_ctime(inode) @@ expression inode; @@ - inode->i_ctime =3D inode->i_mtime =3D current_time(inode) + inode->i_mtime =3D inode_set_current_ctime(inode) @@ struct inode *inode; expression value; @@ - inode->i_ctime =3D value; + inode_set_ctime(inode, value); @@ struct inode *inode; expression val; @@ - inode->i_ctime.tv_sec =3D val + inode_set_ctime_sec(inode, val) @@ struct inode *inode; expression val; @@ - inode->i_ctime.tv_nsec =3D val + inode_set_ctime_nsec(inode, val) @@ struct inode *inode; @@ - inode->i_ctime + inode_ctime_peek(inode)