From: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Coly Li <colyli-l3A5Bk7waGM@public.gmane.org>,
Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Song Liu <song-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
David Sterba <dsterba-IBi9RG/b67k@public.gmane.org>,
Josef Bacik <josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org>,
Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
OGAWA Hirofumi
<hirofumi-UIVanBePwB70ZhReMnHkpc8NsWr+9BEh@public.gmane.org>,
Dave Kleikamp <shaggy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Ryusuke Konishi
<konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Anton Altaparmakov
<anton-yrGDUoBaLx3QT0dZR+AlfA@public.gmane.org>,
Konstantin Komarov
<almaz.alexandrovich-m5I1DM4ARimttCpgsWEBFlaTQe2KTcn/@public.gmane.org>,
Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Phillip Lougher <phillip-Y7wUz+saRi+tmTQ+vhA3Yw@public.gmane.org>,
Jan Kara <jack-IBi9RG/b67k@public.gmane.org>,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org,
linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: don't use ->bd_inode to access the block device size v3
Date: Mon, 18 Oct 2021 11:16:08 -0600 [thread overview]
Message-ID: <4a8c3a39-9cd3-5b2f-6d0f-a16e689755e6@kernel.dk> (raw)
In-Reply-To: <20211018101130.1838532-1-hch-jcswGhMUV9g@public.gmane.org>
On 10/18/21 4:11 AM, Christoph Hellwig wrote:
> Hi Jens,
>
> various drivers currently poke directy at the block device inode, which
> is a bit of a mess. This series cleans up the places that read the
> block device size to use the proper helpers. I have separate patches
> for many of the other bd_inode uses, but this series is already big
> enough as-is,
This looks good to me. Followup question, as it's related - I've got a
hacky patch that caches the inode size in the bdev:
https://git.kernel.dk/cgit/linux-block/commit/?h=perf-wip&id=c754951eb7193258c35a574bd1ccccb7c4946ee4
so we don't have to dip into the inode itself for the fast path. While
it's obviously not something being proposed for inclusion right now, is
there a world in which we can make something like that work?
--
Jens Axboe
next prev parent reply other threads:[~2021-10-18 17:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 10:11 don't use ->bd_inode to access the block device size v3 Christoph Hellwig
2021-10-18 10:11 ` [PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h Christoph Hellwig
2021-10-18 10:11 ` [PATCH 02/30] block: add a bdev_nr_bytes helper Christoph Hellwig
2021-10-18 10:11 ` [PATCH 03/30] bcache: remove bdev_sectors Christoph Hellwig
2021-10-18 10:11 ` [PATCH 04/30] drbd: use bdev_nr_sectors instead of open coding it Christoph Hellwig
2021-10-18 10:11 ` [PATCH 05/30] dm: use bdev_nr_sectors and bdev_nr_bytes instead of open coding them Christoph Hellwig
2021-10-18 10:11 ` [PATCH 06/30] md: use bdev_nr_sectors instead of open coding it Christoph Hellwig
2021-10-18 10:11 ` [PATCH 07/30] nvmet: use bdev_nr_bytes " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 08/30] target/iblock: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 09/30] fs: use bdev_nr_bytes instead of open coding it in blkdev_max_block Christoph Hellwig
2021-10-18 10:11 ` [PATCH 10/30] fs: simplify init_page_buffers Christoph Hellwig
2021-10-18 10:11 ` [PATCH 11/30] affs: use bdev_nr_sectors instead of open coding it Christoph Hellwig
2021-10-18 10:11 ` [PATCH 12/30] btrfs: use bdev_nr_bytes " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 13/30] cramfs: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 14/30] fat: use bdev_nr_sectors " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 15/30] hfs: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 16/30] hfsplus: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 17/30] jfs: use bdev_nr_bytes " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 18/30] nfs/blocklayout: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 19/30] nilfs2: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 20/30] ntfs3: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 21/30] pstore/blk: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 22/30] reiserfs: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 23/30] squashfs: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 24/30] block: use bdev_nr_bytes instead of open coding it in blkdev_fallocate Christoph Hellwig
2021-10-18 10:11 ` [PATCH 25/30] block: add a sb_bdev_nr_blocks helper Christoph Hellwig
2021-10-18 10:11 ` [PATCH 26/30] ext4: use sb_bdev_nr_blocks Christoph Hellwig
2021-10-18 10:11 ` [PATCH 27/30] jfs: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 28/30] ntfs: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 29/30] reiserfs: " Christoph Hellwig
2021-10-18 10:11 ` [PATCH 30/30] udf: " Christoph Hellwig
[not found] ` <20211018101130.1838532-1-hch-jcswGhMUV9g@public.gmane.org>
2021-10-18 17:16 ` Jens Axboe [this message]
[not found] ` <4a8c3a39-9cd3-5b2f-6d0f-a16e689755e6-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2021-10-18 17:18 ` don't use ->bd_inode to access the block device size v3 Christoph Hellwig
[not found] ` <20211018171843.GA3338-jcswGhMUV9g@public.gmane.org>
2021-10-18 17:40 ` Jens Axboe
2021-10-18 17:49 ` Christoph Hellwig
[not found] ` <20211018174901.GA3990-jcswGhMUV9g@public.gmane.org>
2021-10-18 17:53 ` Jens Axboe
[not found] ` <e0784f3e-46c8-c90c-870b-60cc2ed7a2da-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2021-10-18 17:56 ` Christoph Hellwig
2021-10-19 1:04 ` Kari Argillander
2021-10-19 1:04 ` Jens Axboe
2021-10-18 17:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a8c3a39-9cd3-5b2f-6d0f-a16e689755e6@kernel.dk \
--to=axboe-tswwg44o7x1aa/9udqfwiw@public.gmane.org \
--cc=almaz.alexandrovich-m5I1DM4ARimttCpgsWEBFlaTQe2KTcn/@public.gmane.org \
--cc=anton-yrGDUoBaLx3QT0dZR+AlfA@public.gmane.org \
--cc=colyli-l3A5Bk7waGM@public.gmane.org \
--cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org \
--cc=dsterba-IBi9RG/b67k@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=hirofumi-UIVanBePwB70ZhReMnHkpc8NsWr+9BEh@public.gmane.org \
--cc=jack-IBi9RG/b67k@public.gmane.org \
--cc=josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org \
--cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=phillip-Y7wUz+saRi+tmTQ+vhA3Yw@public.gmane.org \
--cc=shaggy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=song-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tytso-3s7WtUTddSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).