From: Bart Van Assche <bvanassche@acm.org>
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH -mm 1/2] nilfs2: use integer type instead of enum req_op for event tracing header
Date: Wed, 1 May 2024 16:42:35 +0200 [thread overview]
Message-ID: <650ed9f6-fa50-4a3b-939d-633f9e389137@acm.org> (raw)
In-Reply-To: <20240430080019.4242-2-konishi.ryusuke@gmail.com>
On 4/30/24 10:00, Ryusuke Konishi wrote:
> trace_nilfs2_mdt_submit_block(inode, inode->i_ino, blkoff,
> - opf & REQ_OP_MASK);
> + (__force int)(opf & REQ_OP_MASK));
Please keep the enum req_op type instead of casting that type away with
"__force int".
Thanks,
Bart.
next prev parent reply other threads:[~2024-05-01 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 8:00 [PATCH -mm 0/2] nilfs2: reduce build warnings with "make C=1" Ryusuke Konishi
2024-04-30 8:00 ` [PATCH -mm 1/2] nilfs2: use integer type instead of enum req_op for event tracing header Ryusuke Konishi
2024-05-01 14:42 ` Bart Van Assche [this message]
2024-05-01 15:30 ` Ryusuke Konishi
2024-05-02 19:01 ` Ryusuke Konishi
2024-05-05 12:47 ` Bart Van Assche
2024-05-05 19:04 ` Ryusuke Konishi
2024-05-06 17:26 ` Bart Van Assche
2024-05-06 21:17 ` Ryusuke Konishi
2024-04-30 8:00 ` [PATCH -mm 2/2] nilfs2: make superblock data array index computation sparse friendly Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=650ed9f6-fa50-4a3b-939d-633f9e389137@acm.org \
--to=bvanassche@acm.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).