From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: don't use ->bd_inode to access the block device size v3 Date: Mon, 18 Oct 2021 19:04:57 -0600 Message-ID: <81f9ad59-4c15-b265-1274-62c987ad879b@kernel.dk> References: <20211018101130.1838532-1-hch@lst.de> <4a8c3a39-9cd3-5b2f-6d0f-a16e689755e6@kernel.dk> <20211018171843.GA3338@lst.de> <2f5dcf79-8419-45ff-c27c-68d43242ccfe@kernel.dk> <20211018174901.GA3990@lst.de> <20211019010416.vgecxu6wnvwi7fii@kari-VirtualBox> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W5z0exFABNpBPX1hRqcH8nqG0V53/7e/1qraB3crDBc=; b=vB+wFpSQtfAUhwdXcfynbmYwp0hdBEQZvbX6X9F6PNzCrR7jlF3UU0FKlXz+m74FXo fYCfnp+UOHId9lQV8O9fyEh4YEI0b538At136V3n0vh4OZ/YzMev/Q7gmlb/eOGGE5cU 0c1i9lZ2acvXLmYa878iz+lCi3R78xqn0ZDpYtIVtZNxoFJsKdSEsj9/YVhugl90Ar3H SoUxghi0wJ6VSD6JvL3P+s/JM6f3Wm0mmMYFgaEag1ojhi+wlEeYXumrYWwARkL2eroz Ue9QqS/6wvsrqGxlajrxCGxhjXwobZTI+icumh8oCIQgK1Jfr75Nwh+NZuFxcTfoqOvP WcvQ== In-Reply-To: <20211019010416.vgecxu6wnvwi7fii@kari-VirtualBox> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Kari Argillander Cc: Dave Kleikamp , jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Mike Snitzer , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Konstantin Komarov , Song Liu , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, reiserfs-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, OGAWA Hirofumi , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kees Cook , Josef Bacik , Coly Li , linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Theodore Ts'o , linux-ntfs-dev@li On 10/18/21 7:04 PM, Kari Argillander wrote: > On Mon, Oct 18, 2021 at 11:53:08AM -0600, Jens Axboe wrote: > > snip.. > >> diff --git a/include/linux/genhd.h b/include/linux/genhd.h >> index 7b0326661a1e..a967b3fb3c71 100644 >> --- a/include/linux/genhd.h >> +++ b/include/linux/genhd.h >> @@ -236,14 +236,14 @@ static inline sector_t get_start_sect(struct block_device *bdev) >> return bdev->bd_start_sect; >> } >> >> -static inline loff_t bdev_nr_bytes(struct block_device *bdev) >> +static inline sector_t bdev_nr_sectors(struct block_device *bdev) >> { >> - return i_size_read(bdev->bd_inode); >> + return bdev->bd_nr_sectors; >> } >> >> -static inline sector_t bdev_nr_sectors(struct block_device *bdev) >> +static inline loff_t bdev_nr_bytes(struct block_device *bdev) >> { >> - return bdev_nr_bytes(bdev) >> SECTOR_SHIFT; >> + return bdev_nr_setors(bdev) << SECTOR_SHIFT; > > setors -> sectors Yep, did catch that prior. -- Jens Axboe