From: Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
To: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Ryusuke Konishi
<konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>,
Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
Subject: [PATCHv2] nilfs2-utils: change the error message of nilfs-tune properlyx
Date: Wed, 15 Sep 2010 16:01:32 +0900 [thread overview]
Message-ID: <8739tbfq2b.wl%jir@sekiba.com> (raw)
Hi,
Change the error message of nilfs-tune when user doesn't have
a permission to access the device to show the cause of error clearly.
differences from v1
- moved the error string behind the primary message.
Signed-off-by: Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
---
sbin/nilfs-tune/nilfs-tune.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sbin/nilfs-tune/nilfs-tune.c b/sbin/nilfs-tune/nilfs-tune.c
index d99ce46..e80caa4 100644
--- a/sbin/nilfs-tune/nilfs-tune.c
+++ b/sbin/nilfs-tune/nilfs-tune.c
@@ -399,10 +399,12 @@ int modify_nilfs(char *device, struct nilfs_tune_options *opts)
struct nilfs_super_block *sbp;
__u64 features;
+ errno = 0;
devfd = open(device, opts->flags);
if (devfd == -1) {
- fprintf(stderr, "%s: cannot open NILFS\n", device);
+ fprintf(stderr, "cannot open device %s: %s\n",
+ device, strerror(errno));
ret = EXIT_FAILURE;
goto out;
}
--
1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2010-09-15 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 7:01 Jiro SEKIBA [this message]
[not found] ` <8739tbfq2b.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2010-09-15 10:39 ` [PATCHv2] nilfs2-utils: change the error message of nilfs-tune properlyx Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739tbfq2b.wl%jir@sekiba.com \
--to=jir-hfpbi5wx9j54eiagz67ipq@public.gmane.org \
--cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
--cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ryusuke-sG5X7nlA6pw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox