From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
Subject: Re: [PATCH 2/3] nilfs2: clean up nilfs_write_super
Date: Sat, 18 Jul 2009 16:00:33 +0900
Message-ID: <87k526qxv2.wl%jir@sekiba.com>
References: <1247821968-31232-1-git-send-email-jir@unicus.jp>
	<1247821968-31232-3-git-send-email-jir@unicus.jp>
	<20090718.012414.19435380.ryusuke@osrg.net>
Reply-To: NILFS Users mailing list <users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <users-bounces-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org>
In-Reply-To: <20090718.012414.19435380.ryusuke-sG5X7nlA6pw@public.gmane.org>
List-Id: <linux-nilfs.vger.kernel.org>
List-Unsubscribe: <https://www.nilfs.org/mailman/listinfo/users>,
	<mailto:users-request-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org?subject=unsubscribe>
List-Archive: <https://www.nilfs.org/pipermail/users>
List-Post: <mailto:users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org>
List-Help: <mailto:users-request-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org?subject=help>
List-Subscribe: <https://www.nilfs.org/mailman/listinfo/users>,
	<mailto:users-request-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org?subject=subscribe>
Sender: users-bounces-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org
Errors-To: users-bounces-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org
To: NILFS Users mailing list <users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org>

Hi,

Thank you for the comments!

At Sat, 18 Jul 2009 01:24:14 +0900 (JST),
Ryusuke Konishi wrote:

> The nilfs_update_super() sounds like a function to do update operation
> on the super block.
> 
> How about nilfs_sb_need_update() or so?

ok, looks better.

> And then, this patch has some style problems.  Applying checkpatch.pl
> can save a bit of time.

Grr.  I might send the wrong one.
I'll revise the patch and resend it again.

regards,
-- 
Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>