From: Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
To: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] nilfs2_ss_manager: fix TypeError at exit
Date: Mon, 07 Feb 2011 12:49:31 +0900 [thread overview]
Message-ID: <87mxm8a4hg.wl%jir@sekiba.com> (raw)
In-Reply-To: <20110206.213453.187450645.ryusuke-sG5X7nlA6pw@public.gmane.org>
At Sun, 06 Feb 2011 21:34:53 +0900 (JST),
Ryusuke Konishi wrote:
>
> On Sun, 6 Feb 2011 21:24:17 +0900, Ryusuke Konishi wrote:
> > Fixes the following error on shutdown:
> >
> > Traceback (most recent call last):
> > File "./nilfs2_ss_manager", line 211, in <module>
> > mainloop.run()
> > TypeError: __exit__() takes exactly 1 argument (4 given)
> >
> > Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
>
> There is a typo on the previous patch.
>
> Please apply the following one instead.
Did you mean "follwoing" as "will send a new mail followed by this"
or as "new patch contained in bottom of this mail" ?
Because the patch in the mail looks same one with before to me.
If you don't mind, I'll fix the bug by myself.
Thank you anyway for the fix!
regards,
> Thanks,
> Ryusuke Konishi
> --
> From: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
>
> nilfs2_ss_manager: fix TypeError at exit
>
> Fixes the following error on shutdown:
>
> Traceback (most recent call last):
> File "./nilfs2_ss_manager", line 211, in <module>
> mainloop.run()
> TypeError: __exit__() takes exactly 1 argument (4 given)
>
> Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> ---
> nilfs2_ss_manager/nilfs2_ss_manager | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/nilfs2_ss_manager/nilfs2_ss_manager b/nilfs2_ss_manager/nilfs2_ss_manager
> index 5821e2a..2243034 100755
> --- a/nilfs2_ss_manager/nilfs2_ss_manager
> +++ b/nilfs2_ss_manager/nilfs2_ss_manager
> @@ -150,7 +150,7 @@ class NODaemonContext:
> def __enter__(self):
> pass
>
> - def __exit__(self):
> + def __exit__(self, *excinfo):
> pass
>
> def register_sighandlers(managers, mainloop):
> --
> 1.7.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
--
Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-07 3:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 12:24 [PATCH] nilfs2_ss_manager: fix TypeError at exit Ryusuke Konishi
[not found] ` <1296995057-30479-1-git-send-email-ryusuke-sG5X7nlA6pw@public.gmane.org>
2011-02-06 12:34 ` Ryusuke Konishi
[not found] ` <20110206.213453.187450645.ryusuke-sG5X7nlA6pw@public.gmane.org>
2011-02-07 3:49 ` Jiro SEKIBA [this message]
[not found] ` <87mxm8a4hg.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2011-02-07 4:13 ` Ryusuke Konishi
[not found] ` <20110207.131318.212382134.ryusuke-sG5X7nlA6pw@public.gmane.org>
2011-02-08 8:42 ` Jiro SEKIBA
[not found] ` <87aai6533k.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2011-02-08 10:52 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxm8a4hg.wl%jir@sekiba.com \
--to=jir-hfpbi5wx9j54eiagz67ipq@public.gmane.org \
--cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ryusuke-sG5X7nlA6pw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).