From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiro SEKIBA Subject: [PATCHv2] nilfs2: eliminate sparse warning - "context imbalance" Date: Wed, 13 Oct 2010 12:41:10 +0900 Message-ID: <87r5fug3op.wl%jir@sekiba.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Return-path: Sender: linux-nilfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Ryusuke Konishi , konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org insert sparse annotations to fix following sparse warning. fs/nilfs2/segment.c:2681:3: warning: context imbalance in 'nilfs_segctor_kill_thread' - unexpected unlock Signed-off-by: Jiro SEKIBA --- fs/nilfs2/segment.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 172ad42..6494e9d 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -2673,7 +2673,14 @@ static int nilfs_segctor_start_thread(struct nilfs_sc_info *sci) return 0; } +/* + * nilfs_segctor_kill_thread is only called inside sc_state_lock lock. + * sparse doesn't detect the context and warn "unexpected unlock". + * __acquires/__releases pretend to lock/unlockk the sc_state_lock for sparse. + */ static void nilfs_segctor_kill_thread(struct nilfs_sc_info *sci) + __acquires(&sci->sc_state_lock) + __releases(&sci->sc_state_lock) { sci->sc_state |= NILFS_SEGCTOR_QUIT; -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html