Re: [PATCH] nilfs2: make splice write available again

[Ryusuke Konishi <konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Hi,

Thank you for quick patch submission.   It looks good at a glance.
I will check the details of the change and will try testing.

Thanks,
Ryusuke Konishi

On Sat, Jan 23, 2021 at 11:39 PM <Joachim.Henke-kyawv7ubMNaakBO8gow8eQ@public.gmane.org> wrote:
>
> Since 5.10, splice() or sendfile() to NILFS2 return EINVAL. This was
> probably caused by commit 36e2c7421f02 ("fs: don't allow splice
> read/write without explicit ops").
>
> This patch initializes the splice_write field in file_operations, like
> most file systems do, to restore the functionality.
>
> Signed-off-by: Joachim Henke <joachim.henke-kyawv7ubMNaakBO8gow8eQ@public.gmane.org>
> ---
>  fs/nilfs2/file.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/nilfs2/file.c b/fs/nilfs2/file.c
> index 64bc81363c6cc..4c7a662047513 100644
> --- a/fs/nilfs2/file.c
> +++ b/fs/nilfs2/file.c
> @@ -141,6 +141,7 @@ const struct file_operations nilfs_file_operations = {
>         /* .release     = nilfs_release_file, */
>         .fsync          = nilfs_sync_file,
>         .splice_read    = generic_file_splice_read,
> +       .splice_write   = iter_file_splice_write,
>  };
>
>  const struct inode_operations nilfs_file_inode_operations = {