From: Xi Wang <xi.wang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ryusuke Konishi
<konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Cc: haogangchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] FS: nilfs2: clamps ns_r_segments_percentage to [1, 99]
Date: Wed, 22 Feb 2012 10:59:25 -0500 [thread overview]
Message-ID: <EC48BE45-EA3E-400B-A90D-FF05CE3426D8@gmail.com> (raw)
In-Reply-To: <20120223.004650.160012804.ryusuke-sG5X7nlA6pw@public.gmane.org>
On Feb 22, 2012, at 10:46 AM, Ryusuke Konishi wrote:
> But this seems not to cause security issues; it just makes some disk
> usage calculations meaningless and causes malfunction for such
> out-of-range values. Right?
Seems true to me.
There may be another issue a few lines above: ns_blocks_per_segment
doesn't seem to have an upper bound (though it has a lower bound
NILFS_SEG_MIN_BLOCKS). ns_blocks_per_segment is used in several
multiplications, such as in nilfs_ioctl_clean_segments:
if (argv[n].v_nmembs > nsegs * nilfs->ns_blocks_per_segment
goto out_free;
Will this cause any problem? Or is there any reasonable upper bound
for ns_blocks_per_segment?
- xi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-22 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 21:55 [PATCH] FS: nilfs2: clamps ns_r_segments_percentage to [1, 99] Haogang Chen
[not found] ` <1329774930-17162-1-git-send-email-haogangchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-22 15:46 ` Ryusuke Konishi
[not found] ` <20120223.004650.160012804.ryusuke-sG5X7nlA6pw@public.gmane.org>
2012-02-22 15:59 ` Xi Wang [this message]
[not found] ` <EC48BE45-EA3E-400B-A90D-FF05CE3426D8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-23 2:31 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EC48BE45-EA3E-400B-A90D-FF05CE3426D8@gmail.com \
--to=xi.wang-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=haogangchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).