From: Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-f2fs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 03/10] ext4: Convert mpage_release_unused_pages() to use filemap_get_folios()
Date: Wed, 8 Jun 2022 17:02:40 +0100 [thread overview]
Message-ID: <YqDIIH2d7iu1o7D0@casper.infradead.org> (raw)
In-Reply-To: <YqBXjjkRZsP8K8fO-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On Wed, Jun 08, 2022 at 01:02:22AM -0700, Christoph Hellwig wrote:
> On Sun, Jun 05, 2022 at 08:38:47PM +0100, Matthew Wilcox (Oracle) wrote:
> > If the folio is large, it may overlap the beginning or end of the
> > unused range. If it does, we need to avoid invalidating it.
>
> It's never going to be larger for ext4, is it? But either way,
> those precautions looks fine.
I don't want to say "never". Today, it's not, but if ext4 ever does
gain support for large folios, then this is a precaution it will need
to take. I'm trying not to leave traps when I do conversions.
> Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
next prev parent reply other threads:[~2022-06-08 16:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 19:38 [PATCH 00/10] Convert to filemap_get_folios() Matthew Wilcox (Oracle)
2022-06-05 19:38 ` [PATCH 01/10] filemap: Add filemap_get_folios() Matthew Wilcox (Oracle)
2022-06-08 8:00 ` Christoph Hellwig
2022-06-05 19:38 ` [PATCH 02/10] buffer: Convert clean_bdev_aliases() to use filemap_get_folios() Matthew Wilcox (Oracle)
2022-06-08 8:01 ` Christoph Hellwig
2022-06-05 19:38 ` [PATCH 04/10] ext4: Convert mpage_map_and_submit_buffers() " Matthew Wilcox (Oracle)
2022-06-08 8:03 ` Christoph Hellwig
2022-06-05 19:38 ` [PATCH 05/10] f2fs: Convert f2fs_invalidate_compress_pages() " Matthew Wilcox (Oracle)
2022-06-08 8:03 ` Christoph Hellwig
2022-06-15 8:14 ` [f2fs-dev] " Chao Yu
2022-06-05 19:38 ` [PATCH 06/10] hugetlbfs: Convert remove_inode_hugepages() " Matthew Wilcox (Oracle)
2022-06-08 8:04 ` Christoph Hellwig
2022-06-10 15:52 ` Sumanth Korikkar
2022-06-10 18:35 ` Gerald Schaefer
2022-06-10 21:17 ` Matthew Wilcox
[not found] ` <YqO08Dsq8ZcAcWDQ-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2022-06-10 21:56 ` Mike Kravetz
2022-06-13 6:56 ` Sumanth Korikkar
2022-06-05 19:38 ` [PATCH 07/10] nilfs2: Convert nilfs_copy_back_pages() " Matthew Wilcox (Oracle)
2022-06-07 16:10 ` Ryusuke Konishi
2022-06-08 8:04 ` Christoph Hellwig
2022-06-05 19:38 ` [PATCH 08/10] vmscan: Add check_move_unevictable_folios() Matthew Wilcox (Oracle)
2022-06-08 8:07 ` Christoph Hellwig
2022-06-08 16:32 ` Matthew Wilcox
[not found] ` <YqDPIv5IgNHK/pJT-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2022-06-09 3:56 ` Christoph Hellwig
2022-06-08 15:33 ` [vmscan] bc9eb0d5ef: BUG:KASAN:stack-out-of-bounds_in_check_move_unevictable_pages kernel test robot
[not found] ` <20220605193854.2371230-1-willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-06-05 19:38 ` [PATCH 03/10] ext4: Convert mpage_release_unused_pages() to use filemap_get_folios() Matthew Wilcox (Oracle)
2022-06-08 8:02 ` Christoph Hellwig
[not found] ` <YqBXjjkRZsP8K8fO-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-06-08 16:02 ` Matthew Wilcox [this message]
[not found] ` <YqDIIH2d7iu1o7D0-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2022-06-09 3:55 ` Christoph Hellwig
2022-06-05 19:38 ` [PATCH 09/10] shmem: Convert shmem_unlock_mapping() " Matthew Wilcox (Oracle)
2022-06-08 8:08 ` Christoph Hellwig
2022-06-07 11:37 ` [PATCH 00/10] Convert to filemap_get_folios() Christian Brauner
2022-06-05 19:38 ` [PATCH 10/10] filemap: Remove find_get_pages_range() and associated functions Matthew Wilcox (Oracle)
2022-06-08 8:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqDIIH2d7iu1o7D0@casper.infradead.org \
--to=willy-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-f2fs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).