From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phillip Potter Subject: Re: [PATCH 02/31] cdrom: remove the unused bdev argument to cdrom_open Date: Tue, 6 Jun 2023 23:50:43 +0100 Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-3-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+5p4OVPssCKpgWSw+CRQtDHxk8LFju7kXWe4mTz7TW0=; b=mzs+gPgtQy7Tp/ OdxA9JlKXChTaTve9gjZS0xZvO2CxrgmHs2PKC1jfSscRr5HmG1C92FXby5qgCdUGiz4wC9feJ2xI HSfa/VAvppw2MKR5vXgS7JpxcxbOaPALHD+A9yJOE4rQHYyIk9lK1nKo3Ylu5697N43wU9OUNgk2E szLX5wZulQsRlfoErZL3DEQwnekBbxXeO6mPcxXWteBgCKtwgKuGZ4txJsaWAZJDVcLGMmK2S3JxA Y1Z1zPfixaumAhi0KQd1uQzDCEtvqjNPG5qz0M5gSzZEI/JM8DCXJkSU4p0J+9iKwZcu4xq8KKoGP qk/qlUZC9rk4ui8huxEg==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20221208.gappssmtp.com; s=20221208; t=1686091846; x=1688683846; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZsgUvAUYrCnrR/1XiT9juxzkogVY5Vs72GapwMni78s=; b=VmbPZldWPYAwRsYyMwk8A03rXJyrpTvXOEYSvwFSEfXYGQ9f0DibZgbOcZv9ahaGKf PI5+OxAdMYvbZGfbUvFF/CsIWyPYoUJBv4adaCgbsLoKZ4qUcAWsIa6Ri3jpTK/bHQrT Ohep93vPQ7ryyJQWAyfDBFxol1ij/mZJMW0A0iwqiwl36LvAZOLX1aeY9L0SpoZCLnJz wVbN864mtnWORoS661vBrZSXNRIiY6AXoBUlqUh/rkIvLh2gwYqiK+WaVFKW8of/Br1s OKeXsZtVkiiCWR6CHlkqhjfmhnyDAQPTMoZhbcUNAf6eh7p56c8hqiOZ1oxWgdRViFlH o2mg== Content-Disposition: inline In-Reply-To: <20230606073950.225178-3-hch@lst.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+glud-user-mode-linux-devel=m.gmane-mx.org@lists.infradead.org To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.ke On Tue, Jun 06, 2023 at 09:39:21AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/cdrom/cdrom.c | 3 +-- > drivers/cdrom/gdrom.c | 2 +- > drivers/scsi/sr.c | 2 +- > include/linux/cdrom.h | 3 +-- > 4 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > index 416f723a2dbb33..e3eab319cb0474 100644 > --- a/drivers/cdrom/cdrom.c > +++ b/drivers/cdrom/cdrom.c > @@ -1155,8 +1155,7 @@ int open_for_data(struct cdrom_device_info *cdi) > * is in their own interest: device control becomes a lot easier > * this way. > */ > -int cdrom_open(struct cdrom_device_info *cdi, struct block_device *bdev, > - fmode_t mode) > +int cdrom_open(struct cdrom_device_info *cdi, fmode_t mode) > { > int ret; > > diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c > index ceded5772aac6d..eaa2d5a90bc82f 100644 > --- a/drivers/cdrom/gdrom.c > +++ b/drivers/cdrom/gdrom.c > @@ -481,7 +481,7 @@ static int gdrom_bdops_open(struct block_device *bdev, fmode_t mode) > bdev_check_media_change(bdev); > > mutex_lock(&gdrom_mutex); > - ret = cdrom_open(gd.cd_info, bdev, mode); > + ret = cdrom_open(gd.cd_info, mode); > mutex_unlock(&gdrom_mutex); > return ret; > } > diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c > index 12869e6d4ebda8..61b83880e395a4 100644 > --- a/drivers/scsi/sr.c > +++ b/drivers/scsi/sr.c > @@ -498,7 +498,7 @@ static int sr_block_open(struct block_device *bdev, fmode_t mode) > sr_revalidate_disk(cd); > > mutex_lock(&cd->lock); > - ret = cdrom_open(&cd->cdi, bdev, mode); > + ret = cdrom_open(&cd->cdi, mode); > mutex_unlock(&cd->lock); > > scsi_autopm_put_device(sdev); > diff --git a/include/linux/cdrom.h b/include/linux/cdrom.h > index 67caa909e3e615..cc5717cb0fa8a8 100644 > --- a/include/linux/cdrom.h > +++ b/include/linux/cdrom.h > @@ -101,8 +101,7 @@ int cdrom_read_tocentry(struct cdrom_device_info *cdi, > struct cdrom_tocentry *entry); > > /* the general block_device operations structure: */ > -extern int cdrom_open(struct cdrom_device_info *cdi, struct block_device *bdev, > - fmode_t mode); > +int cdrom_open(struct cdrom_device_info *cdi, fmode_t mode); > extern void cdrom_release(struct cdrom_device_info *cdi, fmode_t mode); > extern int cdrom_ioctl(struct cdrom_device_info *cdi, struct block_device *bdev, > fmode_t mode, unsigned int cmd, unsigned long arg); > -- > 2.39.2 > Thanks for the patch, looks good to me. Signed-off-by: Phillip Potter Regards, Phil