From: Phillip Potter <phil@philpotter.co.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>,
Josef Bacik <josef@toxicpanda.com>,
"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
Jack Wang <jinpu.wang@ionos.com>, Coly Li <colyli@suse.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>,
dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-um@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release
Date: Thu, 8 Jun 2023 10:44:20 +0100 [thread overview]
Message-ID: <ZIGi9GMGeKruSrrW@equinox> (raw)
In-Reply-To: <20230608090444.GA15075@lst.de>
On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote:
> On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote:
> > Yes indeed - I was under the impression it was appropriate for a
> > maintainer to signal their approval of a patch to maintained code using
> > a Signed-off-by tag due to their involvement in the submission process?
> > Apologies if I've got this wrong, happy to send Reviewed-bys by all
> > means.
>
> Signed-off-by is for the chain that the patches pass through. You add
> it when you apply or forward the patch. Just give me a Reviewed-by
> tag and say it shold apply to patches 1 to 6 and I'll add it.
Thanks for the guidance. Please apply the following to the block patch
(1) and the CD-ROM patches (2-6) of your series, all looks good to me:
Reviewed-by: Phillip Potter <phil@philpotter.co.uk>
Regards,
Phil
next prev parent reply other threads:[~2023-06-08 9:44 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 7:39 decouple block open flags from fmode_t Christoph Hellwig
2023-06-06 7:39 ` [PATCH 01/31] block: also call ->open for incremental partition opens Christoph Hellwig
2023-06-07 8:14 ` Christian Brauner
2023-06-07 8:32 ` Christoph Hellwig
2023-06-07 12:10 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 02/31] cdrom: remove the unused bdev argument to cdrom_open Christoph Hellwig
2023-06-06 22:50 ` Phillip Potter
2023-06-07 8:16 ` Christian Brauner
2023-06-07 12:10 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 03/31] cdrom: remove the unused mode argument to cdrom_ioctl Christoph Hellwig
[not found] ` <20230606073950.225178-4-hch-jcswGhMUV9g@public.gmane.org>
2023-06-06 22:54 ` Phillip Potter
2023-06-07 8:17 ` Christian Brauner
2023-06-07 12:11 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 04/31] cdrom: remove the unused cdrom_close_write release code Christoph Hellwig
[not found] ` <20230606073950.225178-5-hch-jcswGhMUV9g@public.gmane.org>
2023-06-06 22:56 ` Phillip Potter
2023-06-07 8:17 ` Christian Brauner
2023-06-07 12:12 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data Christoph Hellwig
2023-06-06 22:59 ` Phillip Potter
2023-06-07 8:19 ` Christian Brauner
[not found] ` <20230606073950.225178-6-hch-jcswGhMUV9g@public.gmane.org>
2023-06-07 12:13 ` Hannes Reinecke
2023-06-07 12:20 ` Christoph Hellwig
2023-06-06 7:39 ` [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release Christoph Hellwig
[not found] ` <20230606073950.225178-7-hch-jcswGhMUV9g@public.gmane.org>
2023-06-06 23:00 ` Phillip Potter
2023-06-08 8:41 ` Christoph Hellwig
[not found] ` <20230608084129.GA14689-jcswGhMUV9g@public.gmane.org>
2023-06-08 8:47 ` Phillip Potter
2023-06-08 9:04 ` Christoph Hellwig
2023-06-08 9:44 ` Phillip Potter [this message]
2023-06-27 5:41 ` Guenter Roeck
2023-06-07 8:20 ` Christian Brauner
2023-06-07 12:14 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 07/31] block: pass a gendisk on bdev_check_media_change Christoph Hellwig
[not found] ` <20230606073950.225178-8-hch-jcswGhMUV9g@public.gmane.org>
2023-06-07 8:25 ` Christian Brauner
2023-06-07 12:15 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change Christoph Hellwig
2023-06-07 8:26 ` Christian Brauner
2023-06-07 12:19 ` Hannes Reinecke
2023-06-07 12:21 ` Christoph Hellwig
[not found] ` <20230607122131.GB14579-jcswGhMUV9g@public.gmane.org>
2023-06-07 13:18 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 09/31] block: pass a gendisk to ->open Christoph Hellwig
2023-06-07 8:34 ` Christian Brauner
2023-06-07 9:42 ` Jinpu Wang
2023-06-07 12:19 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 10/31] block: remove the unused mode argument to ->release Christoph Hellwig
2023-06-07 8:34 ` Christian Brauner
2023-06-07 9:41 ` Jinpu Wang
2023-06-07 12:20 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 11/31] block: rename blkdev_close to blkdev_release Christoph Hellwig
2023-06-07 8:35 ` Christian Brauner
2023-06-07 12:21 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 12/31] swsusp: don't pass a stack address to blkdev_get_by_path Christoph Hellwig
2023-06-07 12:22 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 13/31] bcache: " Christoph Hellwig
2023-06-07 12:23 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 14/31] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path Christoph Hellwig
[not found] ` <20230606073950.225178-15-hch-jcswGhMUV9g@public.gmane.org>
2023-06-07 8:39 ` Christian Brauner
2023-06-07 9:38 ` Jinpu Wang
2023-06-07 12:24 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 15/31] btrfs: " Christoph Hellwig
2023-06-07 8:40 ` Christian Brauner
2023-06-07 12:24 ` Hannes Reinecke
2023-06-07 13:32 ` David Sterba
2023-06-06 7:39 ` [PATCH 16/31] block: use the holder as indication for exclusive opens Christoph Hellwig
2023-06-07 8:49 ` Christian Brauner
2023-06-07 9:40 ` Jinpu Wang
2023-06-07 12:29 ` Hannes Reinecke
2023-06-07 13:53 ` David Sterba
2023-06-06 7:39 ` [PATCH 17/31] block: add a sb_open_mode helper Christoph Hellwig
2023-06-07 8:55 ` Christian Brauner
2023-06-07 12:30 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 18/31] fs: remove sb->s_mode Christoph Hellwig
2023-06-07 8:56 ` Christian Brauner
2023-06-07 13:01 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool Christoph Hellwig
2023-06-07 8:57 ` Christian Brauner
[not found] ` <20230606073950.225178-20-hch-jcswGhMUV9g@public.gmane.org>
2023-06-07 13:02 ` Hannes Reinecke
2023-06-08 1:18 ` Martin K. Petersen
2023-06-06 7:39 ` [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl " Christoph Hellwig
2023-06-07 8:58 ` Christian Brauner
2023-06-07 13:04 ` Hannes Reinecke
2023-06-08 1:17 ` Martin K. Petersen
2023-06-06 7:39 ` [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn " Christoph Hellwig
2023-06-07 8:58 ` Christian Brauner
2023-06-07 13:05 ` Hannes Reinecke
2023-06-08 1:18 ` Martin K. Petersen
2023-06-06 7:39 ` [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers " Christoph Hellwig
2023-06-07 8:59 ` Christian Brauner
[not found] ` <20230606073950.225178-23-hch-jcswGhMUV9g@public.gmane.org>
2023-06-07 13:06 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 23/31] mtd: block: use a simple bool to track open for write Christoph Hellwig
2023-06-06 8:24 ` Richard Weinberger
2023-06-07 9:00 ` Christian Brauner
2023-06-07 13:07 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 24/31] rnbd-srv: replace sess->open_flags with a "bool readonly" Christoph Hellwig
2023-06-07 9:01 ` Christian Brauner
[not found] ` <20230606073950.225178-25-hch-jcswGhMUV9g@public.gmane.org>
2023-06-07 9:43 ` Jinpu Wang
2023-06-07 13:07 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 25/31] ubd: remove commented out code in ubd_open Christoph Hellwig
2023-06-06 8:20 ` Richard Weinberger
2023-06-07 9:02 ` Christian Brauner
2023-06-07 13:08 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 26/31] block: move a few internal definitions out of blkdev.h Christoph Hellwig
2023-06-07 9:03 ` Christian Brauner
2023-06-07 13:09 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 27/31] block: remove unused fmode_t arguments from ioctl handlers Christoph Hellwig
2023-06-07 9:03 ` Christian Brauner
2023-06-07 13:10 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags Christoph Hellwig
[not found] ` <20230606073950.225178-29-hch-jcswGhMUV9g@public.gmane.org>
2023-06-07 9:21 ` Christian Brauner
2023-06-07 9:32 ` Christian Brauner
2023-06-07 12:16 ` Christoph Hellwig
2023-06-07 12:47 ` Christian Brauner
2023-06-07 9:45 ` Jinpu Wang
2023-06-06 7:39 ` [PATCH 29/31] block: always use I_BDEV on file->f_mapping->host to find the bdev Christoph Hellwig
2023-06-07 9:23 ` Christian Brauner
[not found] ` <20230606073950.225178-30-hch-jcswGhMUV9g@public.gmane.org>
2023-06-07 13:11 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 30/31] block: store the holder in file->private_data Christoph Hellwig
2023-06-07 9:24 ` Christian Brauner
2023-06-07 12:18 ` Christoph Hellwig
[not found] ` <20230606073950.225178-31-hch-jcswGhMUV9g@public.gmane.org>
2023-06-07 13:14 ` Hannes Reinecke
2023-06-06 7:39 ` [PATCH 31/31] fs: remove the now unused FMODE_* flags Christoph Hellwig
2023-06-07 9:25 ` Christian Brauner
[not found] ` <20230606073950.225178-32-hch-jcswGhMUV9g@public.gmane.org>
2023-06-07 13:15 ` Hannes Reinecke
2023-06-06 8:27 ` decouple block open flags from fmode_t Christian Brauner
2023-06-06 8:40 ` Christoph Hellwig
2023-06-07 9:27 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIGi9GMGeKruSrrW@equinox \
--to=phil@philpotter.co.uk \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=clm@fb.com \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@lst.de \
--cc=jinpu.wang@ionos.com \
--cc=josef@toxicpanda.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=miquel.raynal@bootlin.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).