From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A973013DDD0; Tue, 23 Apr 2024 17:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713894686; cv=none; b=ZxEAXAHbygt4wHx5ZXGooMIzh0sRfjows+jHUj9VTFdIvBDoCgWm0LbPPzjzKLmoD9cfmKxZWp6wMGKKU6c9i8t/BGJ8t2RSN6dPyUu5QFHIMFN7G7qGwuVv/lHpvVD3zlVsCYYgiD+ilZbxy7K1GLl1xNtqwACYeKMOZKOE/7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713894686; c=relaxed/simple; bh=hC9rxUeSadKSU2aEXlDrNwf14LNDHBTSKVPnedHJIFk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jr2xsTWAcsee+CtAWSNvZOaWxtVPwVHaIqIZWMrp4X7NsrQ4kfmVCgNGZNVfDglvmrbyFj1ehllAzJLoqs5CCqLY12Zt22zU6wXTijMcrV+3hMT3A6muvpE/QLxDfz9Q0lpvysCVRhosZTf8wBs3wO1REz4fHSDV77aDTep2RzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=W5px8edf; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="W5px8edf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=klyNdKV+mbLyM76gHuHyyUzl+cYj6c4vtjiHIU/fzN8=; b=W5px8edfZMaMlw/2N3A9zcRb3r GTiaRp+u75rrMWquTmYC+LVA83brfQrIO9DrLByEnxVK2bEGQLzL9XwjAdkUfIOV9RQKBb2ir6bfx TDNvwhzVwEr0tMVevPxVW2s1JVLUirK99x3AUtdNhtnXsgZ14ZuVBeMXCFMccwCAG7lh0bCX0v2Kw Hgbm9M4TuNrWp968CWL0TTC0MlvUFqk3rCzX36bYiVhXRejJ33275FRacqFVBTgLWrb3S0SAHQmIi EmSff33FPlG71JJmcRXbPuL+kJb/vTX/qipR1gbPjf+wp1QTC6MF7yiyb3g0zJIyidbWOiMYw2cxw VYPiMmbQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzKIY-0000000Gnth-26Ci; Tue, 23 Apr 2024 17:51:18 +0000 Date: Tue, 23 Apr 2024 18:51:18 +0100 From: Matthew Wilcox To: Ryusuke Konishi Cc: linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 16/30] nilfs2: Remove calls to folio_set_error() and folio_clear_error() Message-ID: References: <20240420025029.2166544-1-willy@infradead.org> <20240420025029.2166544-17-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-nilfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Apr 24, 2024 at 01:36:52AM +0900, Ryusuke Konishi wrote: > On Sat, Apr 20, 2024 at 11:50 AM Matthew Wilcox (Oracle) wrote: > > > > Nobody checks this flag on nilfs2 folios, stop setting and clearing it. > > That lets us simplify nilfs_end_folio_io() slightly. > > > > Cc: Ryusuke Konishi > > Cc: linux-nilfs@vger.kernel.org > > Signed-off-by: Matthew Wilcox (Oracle) > > Looks good to me. Feel free to send this for merging along with other > PG_error removal patches: > > Acked-by: Ryusuke Konishi > > Or if you would like me to pick it up independently (e.g. to gradually > reduce the changes required for removal), I will do so. Please take it through your tree; I'll prepare a pull request for the remainder, but having more patches go through fs maintainers means better testing.