From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hao Xu Subject: Re: [PATCH 07/11] vfs: add nowait parameter for file_accessed() Date: Tue, 29 Aug 2023 15:46:13 +0800 Message-ID: References: <20230827132835.1373581-1-hao.xu@linux.dev> <20230827132835.1373581-8-hao.xu@linux.dev> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WP3nN15JcnIGn7wEIePFcf6LVOuPCzTP32Hu73YPviw=; b=lELz5V2UNXZkNPuo1PMrIwKlW8 r9XKoWafG17zyTHCYLa7HpqdNB0ZiTVlrYBe9mxFpGtrhHLyHkloDWIbU3J+zYpu00L0PjUGchO/g irhhkbb3fHOxMH4ZHDJafTY6OZlxi9Cp9LKi2j8ng8NtTJpfP9aiAnO+e3plqPbW/4f0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WP3nN15JcnIGn7wEIePFcf6LVOuPCzTP32Hu73YPviw=; b=YxhIpuXzp1IXjPGUdAfE3W6NI4 ii4spTNXg+3/ast9wf3tDJ8ZZBGjd/aDtze4B+7tsYKLUqYsZJMERaT6fjXUr6zAo6ok+qfYE09gF DwpkxrorSXcITrgEo59q5dQ3bSqoBhjSwBJXI1fEs3KGpjjFH507/CaXnMVC+uu+xkH0=; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1693295192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WP3nN15JcnIGn7wEIePFcf6LVOuPCzTP32Hu73YPviw=; b=ngCnTfY2JVdB7UbTvhBxaE99SXYf68v1UOzv1oD4Q4J5vfDrhRAI+RinhUow/HJ/SENsM3 ljkpELTTwPgx4fdS1Wsi0U6qZJzH3KEWBSpgNNnZhZo9Ah7qcNPQhnBWxHwyd9Ba5JlzW/ R7n89/DPeOOyD3xIKShExED+0gXsmv8= Content-Language: en-US In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Matthew Wilcox Cc: Wanpeng Li , "Darrick J . Wong" , Dominique Martinet , Dave Chinner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Stefan Roesch , Clay Harris , linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, codalist@coda.cs.cmu.edu, cluster-devel@redhat.com, linux-cachefs@redhat.com, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-block@vger.kernel.org, Alexander Viro , io-uring@vger.kernel.org, Jens Axboe , Christian Brauner , netdev@vger.kernel.org, samba-technical@lists.samba.org, linux-unionfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kerne On 8/28/23 05:32, Matthew Wilcox wrote: > On Sun, Aug 27, 2023 at 09:28:31PM +0800, Hao Xu wrote: >> From: Hao Xu >> >> Add a boolean parameter for file_accessed() to support nowait semantics. >> Currently it is true only with io_uring as its initial caller. > > So why do we need to do this as part of this series? Apparently it > hasn't caused any problems for filemap_read(). > We need this parameter to indicate if nowait semantics should be enforced in touch_atime(), There are locks and maybe IOs in it.