From: Jeff Layton <jlayton@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: lucho@ionkov.net, rafael@kernel.org, djwong@kernel.org,
al@alarsen.net, cmllamas@google.com, andrii@kernel.org,
hughd@google.com, john.johansen@canonical.com,
agordeev@linux.ibm.com, hch@lst.de, hubcap@omnibond.com,
pc@manguebit.com, linux-xfs@vger.kernel.org, bvanassche@acm.org,
jeffxu@chromium.org, mpe@ellerman.id.au, john@keeping.me.uk,
yi.zhang@huawei.com, jmorris@namei.org,
christophe.leroy@csgroup.eu, code@tyhicks.com,
stern@rowland.harvard.edu, borntraeger@linux.ibm.com,
devel@lists.orangefs.org, mirimmad17@gmail.com,
sprasad@microsoft.com, jaharkes@cs.cmu.edu,
linux-um@lists.infradead.org, npiggin@gmail.com,
jlbec@evilplan.org, ericvh@kernel.org, surenb@google.com,
trond.myklebust@hammerspace.com, anton@tuxera.com,
brauner@kernel.org, wsa+renesas@sang-engineering.com,
gregkh@linuxfoundation.org, stephen.smalley.work@gmail.com,
linux-usb@vger.kernel.org, linux-ker
Subject: Re: [PATCH v2 08/92] fs: new helper: simple_rename_timestamp
Date: Tue, 29 Aug 2023 20:48:48 -0400 [thread overview]
Message-ID: <d73e7de5056a34578a193185770e46584450d8b7.camel@kernel.org> (raw)
In-Reply-To: <20230830001917.GC461907@ZenIV>
On Wed, 2023-08-30 at 01:19 +0100, Al Viro wrote:
> On Wed, Jul 05, 2023 at 02:58:11PM -0400, Jeff Layton wrote:
>
> > + * POSIX mandates that the old and new parent directories have their ctime and
> > + * mtime updated, and that inodes of @old_dentry and @new_dentry (if any), have
> > + * their ctime updated.
>
> APPLICATION USAGE
> Some implementations mark for update the last file status change timestamp
> of renamed files and some do not. Applications which make use of the
> last file status change timestamp may behave differently with respect
> to renamed files unless they are designed to allow for either behavior.
>
> So for children POSIX permits rather than mandates. Doesn't really matter;
> Linux behaviour had been to touch ctime on children since way back, if
> not since the very beginning.
Mea culpa. You're quite correct. I'll plan to roll a small patch to
update the comment over this function.
Thanks!
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2023-08-30 0:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230705185812.579118-1-jlayton@kernel.org>
[not found] ` <20230705185812.579118-1-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-07-05 18:58 ` [PATCH v2 07/92] fs: add ctime accessors infrastructure Jeff Layton
2023-07-05 18:58 ` [PATCH v2 08/92] fs: new helper: simple_rename_timestamp Jeff Layton
2023-07-05 18:58 ` [PATCH v2 92/92] fs: rename i_ctime field to __i_ctime Jeff Layton
2023-07-05 21:57 ` [PATCH v2 00/89] fs: new accessors for inode->i_ctime Jeff Layton
[not found] ` <20230705185812.579118-2-jlayton@kernel.org>
[not found] ` <20230705185812.579118-2-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-07-05 23:12 ` [PATCH v2 07/92] fs: add ctime accessors infrastructure Damien Le Moal
[not found] ` <20230705185812.579118-4-jlayton@kernel.org>
[not found] ` <20230705185812.579118-4-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-07-05 23:19 ` [PATCH v2 92/92] fs: rename i_ctime field to __i_ctime Damien Le Moal
2023-07-06 14:58 ` Jan Kara
[not found] ` <a4e6cfec345487fc9ac8ab814a817c79a61b123a.camel@kernel.org>
[not found] ` <a4e6cfec345487fc9ac8ab814a817c79a61b123a.camel-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-07-06 15:16 ` [PATCH v2 00/89] fs: new accessors for inode->i_ctime Eric W. Biederman
2023-07-06 16:14 ` Jeff Layton
2023-07-07 12:42 ` Jeff Layton
2023-07-10 12:35 ` Christian Brauner
2023-07-10 13:32 ` Jeff Layton
2023-07-10 12:18 ` [PATCH v2 00/92] " Christian Brauner
[not found] ` <20230705185812.579118-3-jlayton@kernel.org>
[not found] ` <20230705185812.579118-3-jlayton-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-07-05 23:19 ` [PATCH v2 08/92] fs: new helper: simple_rename_timestamp Damien Le Moal
2023-07-06 10:27 ` Jan Kara
[not found] ` <3b403ef1-22e6-0220-6c9c-435e3444b4d3@kernel.org>
[not found] ` <3b403ef1-22e6-0220-6c9c-435e3444b4d3-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-07-06 0:04 ` Jeff Layton
[not found] ` <7c783969641b67d6ffdfb10e509f382d083c5291.camel@kernel.org>
2023-07-06 21:02 ` [apparmor] " Seth Arnold
2023-07-07 10:50 ` Jeff Layton
2023-08-30 0:19 ` Al Viro
2023-08-30 0:48 ` Jeff Layton [this message]
2023-09-04 18:11 ` [f2fs-dev] [PATCH v2 00/89] fs: new accessors for inode->i_ctime patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d73e7de5056a34578a193185770e46584450d8b7.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=al@alarsen.net \
--cc=andrii@kernel.org \
--cc=anton@tuxera.com \
--cc=borntraeger@linux.ibm.com \
--cc=brauner@kernel.org \
--cc=bvanassche@acm.org \
--cc=christophe.leroy@csgroup.eu \
--cc=cmllamas@google.com \
--cc=code@tyhicks.com \
--cc=devel@lists.orangefs.org \
--cc=djwong@kernel.org \
--cc=ericvh@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=hubcap@omnibond.com \
--cc=hughd@google.com \
--cc=jaharkes@cs.cmu.edu \
--cc=jeffxu@chromium.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=john@keeping.me.uk \
--cc=linux-um@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=mirimmad17@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=pc@manguebit.com \
--cc=rafael@kernel.org \
--cc=sprasad@microsoft.com \
--cc=stephen.smalley.work@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=surenb@google.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wsa+renesas@sang-engineering.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).