From: "Arnd Bergmann" <arnd@arndb.de>
To: "Philipp Stanner" <pstanner@redhat.com>,
"Arnd Bergmann" <arnd@kernel.org>,
linux-kernel@vger.kernel.org,
"Ryusuke Konishi" <konishi.ryusuke@gmail.com>,
"Nathan Chancellor" <nathan@kernel.org>
Cc: "Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian Brauner" <brauner@kernel.org>,
"Jeff Layton" <jlayton@kernel.org>,
"Thorsten Blum" <thorsten.blum@toblux.com>,
linux-nilfs@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 6/9] nilfs2: fix out-of-range warning
Date: Thu, 28 Mar 2024 17:12:03 +0100 [thread overview]
Message-ID: <e96b89e1-0fd7-44c1-a0ed-cd40a5e7af67@app.fastmail.com> (raw)
In-Reply-To: <25b5f2297c98500ed91971a61ccc4bfa5921035e.camel@redhat.com>
On Thu, Mar 28, 2024, at 16:21, Philipp Stanner wrote:
> On Thu, 2024-03-28 at 15:30 +0100, Arnd Bergmann wrote:
>>
>> This is ok, so just shut up that warning with a cast.
>
> nit:
> It's not a warning, but actually a compile error, right?
I build with CONFIG_WERROR=y, which turns all warnings
into errors. It's just a warning without that, and is
currently only enabled when building with 'make W=1',
though the point of my series is to have it always enabled.
> (no idea why they make that an error btw. Warning would be perfectly
> fine)
>
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Should / could that be backported to stable kernels in case people
> start building those with clang-14?
It's clearly harmless and could be backported, but it
is not needed either since older kernels will keep the
option as part of W=1, not the default.
Arnd
next prev parent reply other threads:[~2024-03-28 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 14:30 [PATCH 0/9] address remaining -Wtautological-constant-out-of-range-compare Arnd Bergmann
2024-03-28 14:30 ` [PATCH 6/9] nilfs2: fix out-of-range warning Arnd Bergmann
2024-03-28 15:21 ` Philipp Stanner
2024-03-28 16:12 ` Arnd Bergmann [this message]
2024-03-28 22:04 ` Justin Stitt
2024-03-28 22:25 ` Arnd Bergmann
2024-03-29 9:20 ` Ryusuke Konishi
2024-04-01 8:50 ` (subset) " Christian Brauner
2024-03-29 20:00 ` [PATCH 0/9] address remaining -Wtautological-constant-out-of-range-compare patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e96b89e1-0fd7-44c1-a0ed-cd40a5e7af67@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@kernel.org \
--cc=brauner@kernel.org \
--cc=jlayton@kernel.org \
--cc=justinstitt@google.com \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pstanner@redhat.com \
--cc=thorsten.blum@toblux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).